[compiler] Do not inline IIFEs in value blocks #33548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsavona
approved these changes
Jun 17, 2025
| * We can't handle labels inside expressions yet, so we don't inline IIFEs if they are in a | ||
| * value block. | ||
| */ | ||
| if (block.kind === 'value') { |
There was a problem hiding this comment.
lets invert this, block.kind !== 'block'
There was a problem hiding this comment.
Inverted. In your outer comment I wasn't sure if you meant "variety of kinds of expression blocks" but assumed yes and used the isExpressionBlock helper
As discussed in chat, this is a simple fix to stop introducing labels inside expressions. The useMemo-with-optional test was added in facebook@d70b2c2 and crashes for the same reason- an unexpected label as a value block terminal.
jbrown215
added a commit
that referenced
this pull request
Jun 17, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33546). * #33548 * __->__ #33546
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
As discussed in chat, this is a simple fix to stop introducing labels inside expressions. The useMemo-with-optional test was added in d70b2c2 and crashes for the same reason- an unexpected label as a value block terminal. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33548). * __->__ #33548 * #33546 DiffTrain build for [90bee81](90bee81)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
As discussed in chat, this is a simple fix to stop introducing labels inside expressions. The useMemo-with-optional test was added in d70b2c2 and crashes for the same reason- an unexpected label as a value block terminal. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33548). * __->__ #33548 * #33546 DiffTrain build for [90bee81](90bee81)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33546). * #33548 * __->__ #33546 DiffTrain build for [75e78d2](75e78d2)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33546). * #33548 * __->__ #33546 DiffTrain build for [75e78d2](75e78d2)
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in chat, this is a simple fix to stop introducing labels inside expressions.
The useMemo-with-optional test was added in d70b2c2
and crashes for the same reason- an unexpected label as a value block terminal.
Stack created with Sapling. Best reviewed with ReviewStack.