[Flight] Dedupe objects serialized as Debug Models in a separate set #33583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
Jun 20, 2025
| if ( | ||
| __DEV__ && | ||
| enableAsyncDebugInfo && | ||
| (typeof resolve !== 'function' || !(resolve: any).isReactInternalListener) |
There was a problem hiding this comment.
The microtask here means that cycles don't resolve synchronously which means that console logs can miss them. This is not the only thing that can be async though. If you console log a client reference that hasn't loaded yet you get the same problem.
In the future, we should really make sure that the debug info can be parsed async while retaining console log order.
|
Going to land this so that we can get the deduping in. |
sebmarkbage
added a commit
that referenced
this pull request
Jun 21, 2025
Follow up to #33583. I forgot to rename these too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #33539.
Stores dedupes of
renderConsoleValuein a separate set. This allows us to dedupe objects safely since we can't write objects using this algorithm if they might also be referenced by the "real" serialization.Also renamed it to
renderDebugModelsince it's not just for console anymore.