Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Aug 27, 2025

Stacked on #34299

Helps orienting the currently selected Suspense in the tree. This is the same display as with the Owner hierarchy in the Components tab minus handling overflow. The overflow is just a scrollbar for now.

Probably better to keep the lineage locked while you click in it. At least while we don't have 1st class backwards/forwards navigation.

CleanShot.2025-08-27.at.10.10.42-converted.mp4

@meta-cla meta-cla bot added the CLA Signed label Aug 27, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 27, 2025
@eps1lon eps1lon requested a review from hoxyq August 27, 2025 09:59
@eps1lon eps1lon marked this pull request as ready for review August 27, 2025 09:59
Copy link
Contributor

@hoxyq hoxyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the tree on the left tab of the Suspense panel supposed to be used for it?

With components panel there is a much common scenario where parent stack != owner stack. Is there a value in this for Suspense boundaries, though?


export default function SuspenseBreadcrumbs(): React$Node {
const store = useContext(StoreContext);
useContext(SuspenseTreeStateContext);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unused

@eps1lon
Copy link
Collaborator Author

eps1lon commented Aug 27, 2025

Isn't the tree on the left tab of the Suspense panel supposed to be used for it?

It'll contain named Activity boundaries. #34159 is obsolete.

Helps orienting the currently selected Suspense
in the tree.
@eps1lon eps1lon force-pushed the sebbie/08-26-_devtools_add_breadcrumbs_to_suspense_tab branch from 54827ed to 73d2ecb Compare August 27, 2025 14:01
@eps1lon eps1lon requested a review from hoxyq August 28, 2025 10:22
@eps1lon eps1lon merged commit 89a803f into facebook:main Aug 28, 2025
241 checks passed
@eps1lon eps1lon deleted the sebbie/08-26-_devtools_add_breadcrumbs_to_suspense_tab branch August 28, 2025 14:03
github-actions bot pushed a commit to code/lib-react that referenced this pull request Aug 31, 2025
github-actions bot pushed a commit to code/lib-react that referenced this pull request Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants