Skip to content

[eprh] Update installation instructions in readme #34331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

[eprh] Update installation instructions in readme #34331

merged 1 commit into from
Aug 28, 2025
+24 −11

Conversation

poteto
Copy link
Member

@poteto poteto commented Aug 28, 2025

Small PR to update our readme for eslint-plugin-react-hooks, to better describe what a minimal but complete eslint config would look like.

@poteto
[eprh] Update installation instructions in readme
d3f0e00 
Small PR to update our readme for eslint-plugin-react-hooks, to better describe what a minimal but complete eslint config would look like.
@meta-cla meta-cla bot added the CLA Signed label Aug 28, 2025
@poteto poteto requested a review from josephsavona August 28, 2025 22:20
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 28, 2025
mofeiZ
mofeiZ approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@mofeiZ mofeiZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@react-sizebot
Copy link

Comparing: c5362a3...d3f0e00

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.31 kB 530.31 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 657.78 kB 657.78 kB = 115.66 kB 115.66 kB
facebook-www/ReactDOM-prod.classic.js = 677.76 kB 677.76 kB = 118.94 kB 118.94 kB
facebook-www/ReactDOM-prod.modern.js = 668.19 kB 668.19 kB = 117.26 kB 117.26 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d3f0e00

@poteto poteto merged commit 872b4fe into main Aug 28, 2025
247 checks passed
@poteto poteto deleted the pr34330 branch August 28, 2025 22:27
github-actions bot pushed a commit that referenced this pull request Aug 28, 2025
@poteto
[eprh] Update installation instructions in readme (#34331)
790f9d1 
Small PR to update our readme for eslint-plugin-react-hooks, to better
describe what a minimal but complete eslint config would look like.

DiffTrain build for [872b4fe](872b4fe)
@nextjs-bot nextjs-bot mentioned this pull request Aug 29, 2025
Merged
@ravicious ravicious mentioned this pull request Sep 2, 2025
Merged
EugeneChoi4 pushed a commit to EugeneChoi4/react that referenced this pull request Sep 4, 2025
@poteto @EugeneChoi4
[eprh] Update installation instructions in readme (facebook#34331)
eba0ef8 
Small PR to update our readme for eslint-plugin-react-hooks, to better
describe what a minimal but complete eslint config would look like.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofeiZ mofeiZ mofeiZ approved these changes

@josephsavona josephsavona Awaiting requested review from josephsavona

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poteto @react-sizebot @mofeiZ