Validate node nesting, take 3 #3467
Conversation
|
@sebmarkbage Reactions? |
| null, | ||
| null, // key | ||
| null, // ref | ||
| internalInstance._currentElement._owner, // owner |
There was a problem hiding this comment.
Should we be doing this already? My warning didn't work without it.
|
This doesn't work properly until we actually switch to parent context, right? We have to solve nested renders first. I have another idea that I wanted to pursue with the new refactor. mountComponent/receiveComponent for a composite should return the DOM component to the next DOM component. |
|
No, this works as-is. |
sophiebits
force-pushed
the
valid-3
branch
2 times, most recently
from
a337bf6 to
19658a8
Compare
|
(Updated to validate text nodes and that the container type is valid for the root element too.) |
| @@ -84,6 +84,7 @@ var ReactDOM = mapObject({ | |||
| h6: 'h6', | |||
| head: 'head', | |||
| header: 'header', | |||
| hgroup: 'hgroup', | |||
There was a problem hiding this comment.
But hgroup was dropped from the spec (which is why I never added it). But I guess if it's still supported, fine.
There was a problem hiding this comment.
Oh! Okay, will kill.
There was a problem hiding this comment.
Meh, it doesn't matter too much anymore since React.createElement('hgroup') works
There was a problem hiding this comment.
Guess I'll leave it then.
sophiebits
force-pushed
the
valid-3
branch
3 times, most recently
from
531af87 to
735a20b
Compare
Nicer version of facebook#644 and facebook#735. Fixes facebook#101. Context is neat.
|
We can update this for @sebmarkbage's idea later. |
Validate node nesting, take 3
Nicer version of #644 and #735. Fixes #101. Context is neat.