<option> added children flatten, & warn if invalid #3847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +17,7 @@ var ReactDOMSelect = require('ReactDOMSelect'); | |||
| var ReactElement = require('ReactElement'); | |||
| var ReactInstanceMap = require('ReactInstanceMap'); | |||
| var ReactPropTypes = require('ReactPropTypes'); | |||
| var ReactChildren = require('ReactChildren'); | |||
There was a problem hiding this comment.
Can you put this in alpha order?
|
Just a few inlines – otherwise looks great. If you could make those updates and squash your commits I'll merge. |
reactjs-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@spicyj done 😉 |
| // Flatten children and warn if they aren't strings or numbers; | ||
| // invalid types are ignored. | ||
| ReactChildren.forEach(this.props.children, function(child) { | ||
| if (child == null || child === false) { |
There was a problem hiding this comment.
true didn't get any love?
|
really nice work ! |
| // Flatten children and warn if they aren't strings or numbers; | ||
| // invalid types are ignored. | ||
| ReactChildren.forEach(this.props.children, function(child) { | ||
| if (child == null || typeof child === 'boolean') { |
There was a problem hiding this comment.
You shouldn't need the boolean check here; forEach should map bools to null for you. Can you try removing this? I think your test will still pass.
reactjs-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
done @spicyj |
sophiebits
added a commit
that referenced
this pull request
May 14, 2015
<option> added children flatten, & warn if invalid
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2620