Fix exceptions when running grunt test --debug
#4164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6374,4 +6374,6 @@ CustomElements.addModule(function(scope) { | |||
| window.Platform = scope; | |||
| })(window.WebComponents); | |||
|
|
|||
| module.exports = window.WebComponents; | |||
| if (typeof exports !== 'undefined') { | |||
There was a problem hiding this comment.
Shouldn't this be typeof module? Also, fixed in #4150
There was a problem hiding this comment.
For whatever reason, this seems to be the standard check for a UMD wrapper:
There was a problem hiding this comment.
Ugg, maybe we check for both? It seems highly awkward to attempt to write to a variable called 'module' just because a variable called 'exports' exists (especially since the line would crash fatally if module doesn't exist).
There was a problem hiding this comment.
I think the intention is probably to crash if exports exists but module doesn't because the wrapper doesn't know how to deal with that. I'll leave as-is because I think either should work fine and this seems standard.
|
oh |
sophiebits
added a commit
that referenced
this pull request
Jun 22, 2015
Fix exceptions when running `grunt test --debug`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.