Freeze ReactElement.props in dev mode #4172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimfb
added a commit
that referenced
this pull request
Jun 19, 2015
Freeze ReactElement.props in dev mode
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Jun 24, 2015
Oops. Introduced in facebook#4172.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeze ReactElement.props in dev mode.
This diff removes the dev warning and freezes the props in dev. This means there is a minor divergence in runtime behavior of dev/prod, and breaks devtools (new devtools on the way), but we knew/acknowledged those points. As per @sebmarkbage, we are ok with these facts and still want to freeze.
Details: One might wonder why we freeze some things in the unit tests. This is because phantomjs has a quark where it treats frozen objects as different from non-frozen. Jest and Chrome don't care if things are frozen, but travis uses phantomjs, so, yeah.