Fix event target for input change events. Fixes #4288

[jimfb]

Fix event target for input change events. Fixes #4288

[chicoxyzzy]

Will beta2 be released after merging this?

[jimfb]

@chicoxyzzy Not sure, I'd really like to get the reconciler fix too before beta 2, but we'll see.

@zpao CR? This should be ready to go.

[jimfb]

Ping @zpao

[zpao]

Threading that argument through is pretty annoying :(. Any other cases you missed?

[zpao]

Note for blame hunters (eg me): this is a regression due to #4150.

[jimfb]

Hopefully not missing any others. I did a skim of the uses of nativeEvent, all of them looked reasonable (already have nativeEventTarget or don't need it in that situation).

[vslinko]

@zpao do you have plans for beta2?

[zpao]

Ship it at some point

Edit: sorry, didn't read who asked that (thought it was a teammate who I could be a smart-ass to 😜). I was thinking we'd push out a beta2 sometime soon, maybe this week or next - want to get a few more things in order first.

[richardaday]

+1 on beta2

This bug seems common enough to block most apps immediately after installing to 0.14.0-beta1

[jimfb]

@vslinko @richardaday It's not an officially supported/stable solution, but https://www.npmjs.com/package/react-dom-future stays up-to-date and has these fixes merged. It's what I use for my own testing and stuff. Obviously don't use this in production, but it'll let you play with the latest and greatest features and then you can let us know when we broke things in trunk :).

[chicoxyzzy]

@jimfb thank you!

[vslinko]

@jimfb 🤘

[sophiebits]

@jimfb We already have http://react.zpao.com/builds/master/latest/ which has the latest browser builds as well as the npm packages (.tgz). So you can run

npm install http://react.zpao.com/builds/master/latest/react-dom.tgz

or list that URL as the version spec in package.json. These are updated automatically by Travis.

[jimfb]

Ok, great, that works too!

[syranide]

Was this in beta2/3? I'm still seeing the same issue.

[sophiebits]

Should have been…

[syranide]

Compiling with React(+DOM) 0.14.0-beta3 and event.target === undefined on IE9 in onChange.

[zpao]

Well, the change definitely made it out. But perhaps it wasn't a complete fix.