Added an invariant to throw instead of potentially failing to terminate on unexpected condition. #4502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,6 +129,16 @@ function handleTopLevelWithPath(bookKeeping) { | |||
| // Jump to the root of this React render tree | |||
| while (currentPathElementID !== newRootID) { | |||
| i++; | |||
| if (i > path.length) { | |||
| if (__DEV__) { | |||
| invariant( | |||
There was a problem hiding this comment.
Dev and prod should remain the same - we shouldn't throw in only 1 environment.
…te on unexpected condition.
jimfb
force-pushed
the
fallback-to-old-algorithm
branch
from
afc55e4 to
04f070f
Compare
|
Going to abandon this in favor of #4558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an invariant to throw instead of potentially failing to terminate on unexpected condition.