Minimal implementation of stateless components #4587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't be much change. Notably, this calls `.getName()` instead of trying to derive it manually, which is more consistent.
|
cc @sebmarkbage @vslinko: Thanks for your work in #3995. We're planning to go with a minimal implementation for now but let's keep your other PR open to see if we want to pull it in for 0.15. |
Stateless pure-function components give us more opportunity to make performance optimizations. For now, we'll do a minimal implementation which has similar performance characteristics to other components in the interests of shipping 0.14 and allowing people to begin writing code using this pattern; in the future we can refactor to allocate less and avoid other unnecessary work.
sophiebits
force-pushed
the
stateless-fn
branch
from
998129a to
5a7bd96
Compare
|
@spicyj ok, agreed |
|
lgtm |
sophiebits
added a commit
that referenced
this pull request
Aug 11, 2015
Minimal implementation of stateless components
| inst = new Component(publicProps, publicContext, ReactUpdateQueue); | ||
| } | ||
|
|
||
| if (inst === null || inst === false || ReactElement.isValidElement(inst)) { |
There was a problem hiding this comment.
This won't work because the construct trap will intercept any non-object and turn it into this. :(
Merged
|
@spicyj I'm not sure: are there plans for the stateless function component to be handled as being pure and thus avoiding repeated calls (to render the output) if the properties provided stay unchanged (with respect to a |
|
@epsitec You can read the relevant discussion is here: #3995 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stateless pure-function components give us more opportunity to make performance optimizations. For now, we'll do a minimal implementation which has similar performance characteristics to other components in the interests of shipping 0.14 and allowing people to begin writing code using this pattern; in the future we can refactor to allocate less and avoid other unnecessary work.
This adapts @vslinko's tests from #3995.