Skip to content

Build react dom browser 2 #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2015
Merged

Build react dom browser 2 #4814

merged 4 commits into from
Sep 9, 2015

Conversation

zpao
Copy link
Member

@zpao zpao commented Sep 9, 2015

Supersedes #4761

  • send to build server
  • rename to .min?
  • make sure it's bundled in all the places (eg, bower)
  • update examples (can happen after if we want)

@sophiebits
Copy link
Collaborator

Can we make a .js and a .min.js for consistency? If people don't look too closely they might not notice that it's three lines.

@zpao
Copy link
Member Author

zpao commented Sep 9, 2015

Sure

@zpao zpao mentioned this pull request Sep 9, 2015
Closed
5 tasks
cpojer
cpojer reviewed Sep 9, 2015
View reviewed changes
src/React.js
@@ -64,4 +64,6 @@ assign(React, {
),
});

React.__sekret_DOM_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = ReactDOM;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, I thought this was a joke? In German, Sekret means secretion, so not exactly the word you are looking for here. Use "Geheimnis" instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's not the word we're looking for here? (ew)

@zpao zpao force-pushed the build-react-dom-browser-2 branch from f7d5c4f to 3cbe7ba Compare September 9, 2015 05:00
@zpao zpao force-pushed the build-react-dom-browser-2 branch from 3cbe7ba to 3e67201 Compare September 9, 2015 05:20
@zpao zpao mentioned this pull request Sep 9, 2015
Closed
@zpao
Copy link
Member Author

zpao commented Sep 9, 2015

I changed it to __SECRET_DOM_DO_NOT_USE_OR_YOU_WILL_BE_FIRED to make our German friends less grossed out. I'm going to do the examples in a separate PR.

zpao added a commit that referenced this pull request Sep 9, 2015
@zpao
Merge pull request #4814 from zpao/build-react-dom-browser-2
69ab714 
Build react dom browser 2
@zpao zpao merged commit 69ab714 into facebook:master Sep 9, 2015
@sophiebits sophiebits mentioned this pull request Sep 9, 2015
Closed
@zpao zpao mentioned this pull request Sep 21, 2015
Merged
@zpao zpao deleted the build-react-dom-browser-2 branch October 13, 2015 16:40
@kevinrobinson kevinrobinson mentioned this pull request Nov 3, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zpao @sophiebits @cpojer @LeonFedotov @bgammill @alvaropinot @facebook-github-bot