Skip to content

React -> ReactDOM for render() and findDOMNode() #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2015
Merged

React -> ReactDOM for render() and findDOMNode() #5055

merged 1 commit into from
Oct 6, 2015

Conversation

jimfb
Copy link
Contributor

@jimfb jimfb commented Oct 5, 2015

React -> ReactDOM for render() and findDOMNode()

@zpao zpao mentioned this pull request Oct 5, 2015
Closed
17 tasks
@jimfb jimfb added this to the 0.14 milestone Oct 5, 2015
@sophiebits
Copy link
Collaborator

Do the in-website examples (docs/_js) still run okay?

@jimfb
Copy link
Contributor Author

jimfb commented Oct 6, 2015

Are those the examples on the homepage (http://localhost:4000/react/)? If so, yes, they ran happily.

@sophiebits
Copy link
Collaborator

Yes. You need to run rake in docs/ to rebuild the compiled JS files.

@jimfb
Copy link
Contributor Author

jimfb commented Oct 6, 2015

Done.

jimfb added a commit that referenced this pull request Oct 6, 2015
@jimfb
Merge pull request #5055 from jimfb/reactdom-render
ff533cb 
React -> ReactDOM for render() and findDOMNode()
@jimfb jimfb merged commit ff533cb into facebook:master Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@jimfb @sophiebits @facebook-github-bot