Skip to content

docs dangerouslySetInnerHTML #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs dangerouslySetInnerHTML #588

wants to merge 1 commit into from

Conversation

chenglou
Copy link
Contributor

#413

Any feedback on the wording?

@Daniel15
Copy link
Member

The JSX Gotchas page touches on this, maybe link to one of the pages you modified from that page (like a "For more information, see this other page")?

@chenglou
Copy link
Contributor Author

I guess I could. None of the two modified page brings new info to the api though

@sophiebits
Copy link
Collaborator

The tutorial shouldn't be the canonical reference that other things point to; I think the reference section should be self-contained.

Maybe a new "Special Attributes" or "Special Props" section of the reference is in order that talks about children, dangerouslySetInnerHTML, key, and ref.

@chenglou
Copy link
Contributor Author

That's a good idea. I'll do that soon.

@zpao
Copy link
Member

zpao commented Dec 6, 2013

Any update?

@chenglou
Copy link
Contributor Author

chenglou commented Dec 6, 2013

@zpao do you need the docs soon? Exams over next week only.

@zpao
Copy link
Member

zpao commented Dec 6, 2013

No rush, just checking in. Focus on exams!

On Dec 5, 2013, at 8:36 PM, "Cheng Lou" <[email protected]mailto:[email protected]> wrote:

@zpaohttps://urldefense.proofpoint.com/v1/url?u=https://github.com/zpao&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=laHZhPsrTTGL9mHVyUC%2BICFnZxZCH4LNzfo%2BOgrHdsw%3D%0A&m=LdkvWdkr9U88A6QngkFwaMCMol9O7TuUs%2F1EDSr4zYI%3D%0A&s=6a83bf04a7d76f89f31b8e6b891cbb862ef3f80314e1f084613a5a1e304271ef do you need the docs soon? Exams over next week only.


Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v1/url?u=#588.

@chenglou
Copy link
Contributor Author

closed in favour of ^

@chenglou chenglou closed this Dec 18, 2013
@chenglou chenglou deleted the danger-docs branch December 18, 2013 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants