Skip to content

Upgrade envify to a version that uses recast #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2013
Merged

Upgrade envify to a version that uses recast #662

merged 1 commit into from
Dec 22, 2013

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Dec 13, 2013

Upstream pull request was accepted! hughsk/envify#4

@petehunt
Copy link
Contributor

This needs to go through the same browserify transform that's provided in the package.json of the react npm module. If we don't then I fear we're going to screw something up when people try to use envify.

So if we want to do this we should either release an alternative to envify that we can refer to in the package.json or try to get a PR accepted on envify.

@andreypopp
Copy link
Contributor

If you put your version of envify into the react npm package you can refer to it with ./envify in package.json. But PR to envify would be nice too — recast is so much better for these things!

@benjamn
Copy link
Contributor Author

benjamn commented Dec 17, 2013

Submitted a PR to envify: hughsk/envify#4

@benjamn benjamn closed this Dec 17, 2013
@benjamn benjamn reopened this Dec 19, 2013
@petehunt
Copy link
Contributor

I think this PR needs to be rebased or something -- has a lot of extra stuff in it. Once you do let's do this!

@benjamn
Upgrade envify dependency to v1.0.1.
9da3f92 
This version uses Recast for source transformation:
hughsk/envify#4
benjamn added a commit that referenced this pull request Dec 22, 2013
@benjamn
Merge pull request #662 from benjamn/replace-envify
9f3c4da 
Upgrade envify to a version that uses recast.
@benjamn benjamn merged commit 9f3c4da into facebook:master Dec 22, 2013
@benjamn benjamn deleted the replace-envify branch December 22, 2013 17:39
This was referenced Mar 4, 2021
Open
Open
josephsavona pushed a commit that referenced this pull request May 15, 2024
@kassens
Invariant for use before definition of reactive values (#662)
b1006e1
lubieowoce added a commit to vercel/next.js that referenced this pull request May 21, 2024
@lubieowoce
Update React from 04b058868c to d3ce0d3ea9
2e16f0c 
### React upstream changes

-  75871d7de [ssa] Add support for other kinds of Instructions (Sathya Gunasekaran)
-  bb91cbbf6 [hir][be] Use a Map to store ObjectExpression.properties  (Sathya Gunasekaran)
-  f54d121d7 [hir][be] Use a Map to store JsxExpression.props  (Sathya Gunasekaran)
-  c347e8b6d [ssa][be] Delete dead code  (Sathya Gunasekaran)
-  152c3e81d [hir][be] Use .kind() to update and find ValueKind (Sathya Gunasekaran)
-  f4df34542 Improve playground validation, workaround lack of JSX support  (Joseph Savona)
-  a7450572f import runtime from "React.unstable_ForgetRuntime"  (Joseph Savona)
-  2f34f8501 Enable no-use-before-define validation in playground  (Joseph Savona)
-  00a58cdab Option to validate output with ESLint  (Joseph Savona)
-  94f1e6f27 Add runtime dependencies to the dependencies  (Jan Kassens)
-  eeb01b17e [ssa] Remove lambdas for update functions  (Sathya Gunasekaran)
-  b9ce8bdcf [SSA] Fix identifierID hack  (Sathya Gunasekaran)
-  379251c65 Add SSA-ify pass  (Sathya Gunasekaran)
-  9524c5848 Replace `import from '.'` with path name  (Jan Kassens)
-  95fe4ed0e Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  704d93600 [easy] rename InferReference{Capability=>Effects}  (Joseph Savona)
-  471201774 Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  46d7f4f8a Synchronize symbol names with React  (Lauren Tan)
-  b03752cbe Use for loop instead of Array.prototype.fill  (Lauren Tan)
-  90e189ae8 Add react-forget-runtime  (Jan Kassens)
-  8f42eda43 Provide full path to tsc  (Lauren Tan)
-  9e8224cc5 Pass `init` to E0007 diagnostic  (Lauren Tan)
-  33735b90f Add a ts:analyze-trace command  (Lauren Tan)
-  e939cacf9 Don't console.error in dev  (Lauren Tan)
-  101ee3a44 Allow capitalized function identifiers to be allowlisted  (Lauren Tan)
-  58100e3d6 Use CompilerError invariant  (Lauren Tan)
- facebook/react#662
-  0000ab6ca [new-arch] HIR cleanup per discussion  (Joseph Savona)
-  73059d9a4 [Playground][Nit] Add delete + overtype for autoclosing brackets  (mofeiZ)
-  144e85626 Cleanup reverse postordering  (Joseph Savona)
-  b01fbfa7f Change function parameters to type Place  (Sathya Gunasekaran)
-  5149ce0fb [new-arch] Store HIR blocks in reverse postorder  (Joseph Savona)
-  3d4130140 [new-arch] Scaffolding and fixtures for mutability lifetime inference  (Joseph Savona)
- facebook/react#651
-  beb6e1431 [new-arch] Improve reference-kind analysis  (Joseph Savona)
-  7f17dd84d Import useMemoCache from unstable name  (Jan Kassens)
-  e575e2292 Add hash of Babel plugin to Jest transform  (Jan Kassens)
-  b605fc1ab [BE] Even more permissive ref annotation comment  (Xuan Huang (黄玄))
-  a574d1598 [Fix] Control Dep Should Only Add To Defs  (Xuan Huang (黄玄))
-  19b08e67a [Bailout] When Inputs Detected In DepGraph Cycle  (Xuan Huang (黄玄))
-  cbbfba27b [new-arch][easy] Handle declarations (let/const) through codegen  (Joseph Savona)
-  90ab34650 [new-arch][easy] Codegen for switch statements  (Joseph Savona)
-  f5f914338 [new-architecture] Reassignment-safe frozenness inference  (Joseph Savona)
-  e877f89dd Allow comment annotation to be spaced  (Xuan Huang (黄玄))
-  83f3999a2 Support var declaration hoisting  (Xuan Huang (黄玄))
-  896ef251b patch makeReadOnly into playground (Mofei Zhang)
-  4e0639c2d Add makeReadOnly codegen into the compiler (Mofei Zhang)
-  72775fba1 makeReadOnly implementation  (Mofei Zhang)
- facebook/react#589
-  a33c0b897 Initial commit (Xuan Huang (黄玄))
- facebook/react#29026
@lubieowoce lubieowoce mentioned this pull request May 21, 2024
Merged
lubieowoce added a commit to vercel/next.js that referenced this pull request May 21, 2024
@lubieowoce
Update React from 04b058868c to d3ce0d3ea9
4163dcb 
### React upstream changes

-  75871d7de [ssa] Add support for other kinds of Instructions (Sathya Gunasekaran)
-  bb91cbbf6 [hir][be] Use a Map to store ObjectExpression.properties  (Sathya Gunasekaran)
-  f54d121d7 [hir][be] Use a Map to store JsxExpression.props  (Sathya Gunasekaran)
-  c347e8b6d [ssa][be] Delete dead code  (Sathya Gunasekaran)
-  152c3e81d [hir][be] Use .kind() to update and find ValueKind (Sathya Gunasekaran)
-  f4df34542 Improve playground validation, workaround lack of JSX support  (Joseph Savona)
-  a7450572f import runtime from "React.unstable_ForgetRuntime"  (Joseph Savona)
-  2f34f8501 Enable no-use-before-define validation in playground  (Joseph Savona)
-  00a58cdab Option to validate output with ESLint  (Joseph Savona)
-  94f1e6f27 Add runtime dependencies to the dependencies  (Jan Kassens)
-  eeb01b17e [ssa] Remove lambdas for update functions  (Sathya Gunasekaran)
-  b9ce8bdcf [SSA] Fix identifierID hack  (Sathya Gunasekaran)
-  379251c65 Add SSA-ify pass  (Sathya Gunasekaran)
-  9524c5848 Replace `import from '.'` with path name  (Jan Kassens)
-  95fe4ed0e Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  704d93600 [easy] rename InferReference{Capability=>Effects}  (Joseph Savona)
-  471201774 Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  46d7f4f8a Synchronize symbol names with React  (Lauren Tan)
-  b03752cbe Use for loop instead of Array.prototype.fill  (Lauren Tan)
-  90e189ae8 Add react-forget-runtime  (Jan Kassens)
-  8f42eda43 Provide full path to tsc  (Lauren Tan)
-  9e8224cc5 Pass `init` to E0007 diagnostic  (Lauren Tan)
-  33735b90f Add a ts:analyze-trace command  (Lauren Tan)
-  e939cacf9 Don't console.error in dev  (Lauren Tan)
-  101ee3a44 Allow capitalized function identifiers to be allowlisted  (Lauren Tan)
-  58100e3d6 Use CompilerError invariant  (Lauren Tan)
- facebook/react#662
-  0000ab6ca [new-arch] HIR cleanup per discussion  (Joseph Savona)
-  73059d9a4 [Playground][Nit] Add delete + overtype for autoclosing brackets  (mofeiZ)
-  144e85626 Cleanup reverse postordering  (Joseph Savona)
-  b01fbfa7f Change function parameters to type Place  (Sathya Gunasekaran)
-  5149ce0fb [new-arch] Store HIR blocks in reverse postorder  (Joseph Savona)
-  3d4130140 [new-arch] Scaffolding and fixtures for mutability lifetime inference  (Joseph Savona)
- facebook/react#651
-  beb6e1431 [new-arch] Improve reference-kind analysis  (Joseph Savona)
-  7f17dd84d Import useMemoCache from unstable name  (Jan Kassens)
-  e575e2292 Add hash of Babel plugin to Jest transform  (Jan Kassens)
-  b605fc1ab [BE] Even more permissive ref annotation comment  (Xuan Huang (黄玄))
-  a574d1598 [Fix] Control Dep Should Only Add To Defs  (Xuan Huang (黄玄))
-  19b08e67a [Bailout] When Inputs Detected In DepGraph Cycle  (Xuan Huang (黄玄))
-  cbbfba27b [new-arch][easy] Handle declarations (let/const) through codegen  (Joseph Savona)
-  90ab34650 [new-arch][easy] Codegen for switch statements  (Joseph Savona)
-  f5f914338 [new-architecture] Reassignment-safe frozenness inference  (Joseph Savona)
-  e877f89dd Allow comment annotation to be spaced  (Xuan Huang (黄玄))
-  83f3999a2 Support var declaration hoisting  (Xuan Huang (黄玄))
-  896ef251b patch makeReadOnly into playground (Mofei Zhang)
-  4e0639c2d Add makeReadOnly codegen into the compiler (Mofei Zhang)
-  72775fba1 makeReadOnly implementation  (Mofei Zhang)
- facebook/react#589
-  a33c0b897 Initial commit (Xuan Huang (黄玄))
- facebook/react#29026
lubieowoce added a commit to vercel/next.js that referenced this pull request May 21, 2024
@lubieowoce
Update React from 04b058868c to d3ce0d3ea9
6761b98 
### React upstream changes

-  75871d7de [ssa] Add support for other kinds of Instructions (Sathya Gunasekaran)
-  bb91cbbf6 [hir][be] Use a Map to store ObjectExpression.properties  (Sathya Gunasekaran)
-  f54d121d7 [hir][be] Use a Map to store JsxExpression.props  (Sathya Gunasekaran)
-  c347e8b6d [ssa][be] Delete dead code  (Sathya Gunasekaran)
-  152c3e81d [hir][be] Use .kind() to update and find ValueKind (Sathya Gunasekaran)
-  f4df34542 Improve playground validation, workaround lack of JSX support  (Joseph Savona)
-  a7450572f import runtime from "React.unstable_ForgetRuntime"  (Joseph Savona)
-  2f34f8501 Enable no-use-before-define validation in playground  (Joseph Savona)
-  00a58cdab Option to validate output with ESLint  (Joseph Savona)
-  94f1e6f27 Add runtime dependencies to the dependencies  (Jan Kassens)
-  eeb01b17e [ssa] Remove lambdas for update functions  (Sathya Gunasekaran)
-  b9ce8bdcf [SSA] Fix identifierID hack  (Sathya Gunasekaran)
-  379251c65 Add SSA-ify pass  (Sathya Gunasekaran)
-  9524c5848 Replace `import from '.'` with path name  (Jan Kassens)
-  95fe4ed0e Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  704d93600 [easy] rename InferReference{Capability=>Effects}  (Joseph Savona)
-  471201774 Include `Utils.Component()` in BailOnCapitalizedFunctionCalls  (Tianyu Yao)
-  46d7f4f8a Synchronize symbol names with React  (Lauren Tan)
-  b03752cbe Use for loop instead of Array.prototype.fill  (Lauren Tan)
-  90e189ae8 Add react-forget-runtime  (Jan Kassens)
-  8f42eda43 Provide full path to tsc  (Lauren Tan)
-  9e8224cc5 Pass `init` to E0007 diagnostic  (Lauren Tan)
-  33735b90f Add a ts:analyze-trace command  (Lauren Tan)
-  e939cacf9 Don't console.error in dev  (Lauren Tan)
-  101ee3a44 Allow capitalized function identifiers to be allowlisted  (Lauren Tan)
-  58100e3d6 Use CompilerError invariant  (Lauren Tan)
- facebook/react#662
-  0000ab6ca [new-arch] HIR cleanup per discussion  (Joseph Savona)
-  73059d9a4 [Playground][Nit] Add delete + overtype for autoclosing brackets  (mofeiZ)
-  144e85626 Cleanup reverse postordering  (Joseph Savona)
-  b01fbfa7f Change function parameters to type Place  (Sathya Gunasekaran)
-  5149ce0fb [new-arch] Store HIR blocks in reverse postorder  (Joseph Savona)
-  3d4130140 [new-arch] Scaffolding and fixtures for mutability lifetime inference  (Joseph Savona)
- facebook/react#651
-  beb6e1431 [new-arch] Improve reference-kind analysis  (Joseph Savona)
-  7f17dd84d Import useMemoCache from unstable name  (Jan Kassens)
-  e575e2292 Add hash of Babel plugin to Jest transform  (Jan Kassens)
-  b605fc1ab [BE] Even more permissive ref annotation comment  (Xuan Huang (黄玄))
-  a574d1598 [Fix] Control Dep Should Only Add To Defs  (Xuan Huang (黄玄))
-  19b08e67a [Bailout] When Inputs Detected In DepGraph Cycle  (Xuan Huang (黄玄))
-  cbbfba27b [new-arch][easy] Handle declarations (let/const) through codegen  (Joseph Savona)
-  90ab34650 [new-arch][easy] Codegen for switch statements  (Joseph Savona)
-  f5f914338 [new-architecture] Reassignment-safe frozenness inference  (Joseph Savona)
-  e877f89dd Allow comment annotation to be spaced  (Xuan Huang (黄玄))
-  83f3999a2 Support var declaration hoisting  (Xuan Huang (黄玄))
-  896ef251b patch makeReadOnly into playground (Mofei Zhang)
-  4e0639c2d Add makeReadOnly codegen into the compiler (Mofei Zhang)
-  72775fba1 makeReadOnly implementation  (Mofei Zhang)
- facebook/react#589
-  a33c0b897 Initial commit (Xuan Huang (黄玄))
- facebook/react#29026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Build Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjamn @petehunt @andreypopp