Remove unneeded declare #7570
Merged
Remove unneeded declare #7570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
|
| @@ -52,15 +52,6 @@ type Item = { | |||
| updateCount: number, | |||
| }; | |||
There was a problem hiding this comment.
So is Item truly unused now?
There was a problem hiding this comment.
That's correct! Less code needed :)
It turns out that we don't need it, flow is smart enough to realize that the function is declared in the two branches :)
vjeux
force-pushed
the
remove_uneeded_declare
branch
from
24379b6 to
a545d5b
Compare
|
Rebased and removed the Item type declaration |
|
awesome |
zpao
pushed a commit
that referenced
this pull request
Oct 4, 2016
It turns out that we don't need it, flow is smart enough to realize that the function is declared in the two branches :) (cherry picked from commit b977cf1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we don't need it, flow is smart enough to realize that the function is declared in the two branches :)