Optional queue transitions #8158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Able to force transition reset instead of waiting old transition to finish
transisionQueue
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status. |
|
Hi, thanks for the PR! The problem is, we don't actively maintain TransitionGroup, and won't be able to review PRs adding new functionality to it. I encourage you to join the discussion in #8125 to figure out a way forward for it, and maybe help maintain it. Thanks, and sorry about closing the PR (we really appreciate your work!) |
|
Checkout this project as an alternative: https://github.com/wikiwi/react-css-transition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now ReactCSSTransitionGroup forces ending one transition to start the next one. This is not the behaviour everyone wants, so I added a
transitionQueueproperty which istrueby default, and if set tofalsewill disable transitions queues, so will force ending the current transition and inmediatelly start the next one.I added this because I wanted
transitionLeaveto start as soon an element is removed, instead of waiting fortransitionEnterto finish.