Skip to content

Conversation

syranide
Copy link
Contributor

@syranide syranide commented Jan 9, 2014

@spicyj added the the useful onLoad, lets complement it with onError for those times the images doesn't load. :)

It is possible that we may want to overload onLoad to sometimes emit onError instead. I've seen people comment in various places that sometimes images fails to load but emit onLoad with 0 width/height image instead. But I wasn't able to reproduce it myself in IE8-11 and edge versions of browsers.

@petehunt
Copy link
Contributor

petehunt commented Jan 9, 2014

seems legit

@vjeux
Copy link
Contributor

vjeux commented Jan 9, 2014

For FB people going to take this kind of code. When pulling in, make sure that you check for existing code that uses the same name using onError=. For onLoad it broke two call sites that accidentally transferred it to DOM nodes using this.transferPropsTo.

@syranide
Copy link
Contributor Author

@petehunt Rebased.

@petehunt
Copy link
Contributor

pulling in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants