-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Rename "External Matchfinder" to "Block-Level Sequence Producer" #3484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embg
commented
Feb 8, 2023
embg
commented
Feb 8, 2023
Cyan4973
reviewed
Feb 8, 2023
fad2aad
to
5436584
Compare
d42b227
to
824f412
Compare
Cyan4973
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"External matchfinder" was an inaccurate name, since the user-provided callback selects which match to use at each position as well as finding multiple matches for each position. The updated term we are using is "sequence provider".
Original PR introducing the old term (title of the old PR has been updated): #3333
Here are the commands I used to migrate names in
lib/
andtests/
:TODOs:
contrib/externalMatchfinder
lib/
andtests/
. Not a release blocker for 1.5.4 since it's all internal.