Bugfixed Visual Studio errors when compiled as C++ sources

[r-lyeh-archived]

Hello Yann,

Here you have a few missing casts.
They're not required in C, but library will fail to compile in C++ mode otherwise
(reproduce it by typìng cl.exe /Tp fse.c and cl.exe /Tp zstd.c)

Great library.
Keep up the good work.

• r-lyeh

PS: I have kept your identation style when creating the type casts. Also, see errors bugfixed below:

fse.c(135) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(148) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(169) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(183) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(621) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const rank_t *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(622) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const rank_t *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(1008) : error C2440: 'initializing' : cannot convert from 'void *' to 'U32 *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(1026) : error C2440: 'initializing' : cannot convert from 'void *' to 'U32 *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(1145) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const U32 *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
fse.c(1514) : error C2440: 'initializing' : cannot convert from 'void *' to 'U32 *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast

zstd.c(205) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(206) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(213) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(230) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(279) : error C2440: 'initializing' : cannot convert from 'ZSTD_cctx_t' to 'refTables_t *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(440) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(461) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(954) : error C2664: 'size_t ZSTD_compressEntropy(BYTE *,size_t,const BYTE *,const BYTE *,const BYTE *,const BYTE *,const BYTE *,const U32 *,const BYTE *,const BYTE *,size_t,size_t)' : cannot convert argument 1 from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1001) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1003) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1009) : error C2440: '=' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1013) : error C2440: '=' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1068) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1085) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1133) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1142) : error C2440: '=' : cannot convert from 'int' to 'blockType_t' Conversion to enumeration type requires an explicit cast (static_cast, C-style cast or function-style cast)
zstd.c(1233) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1261) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1263) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1303) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1397) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1399) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1561) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1563) : error C2440: 'initializing' : cannot convert from 'void *' to 'BYTE *const ' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1640) : error C2440: 'initializing' : cannot convert from 'void *' to 'dctx_t *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast
zstd.c(1698) : error C2440: 'initializing' : cannot convert from 'const void *' to 'const BYTE *' Conversion from 'void*' to pointer to non-'void' requires an explicit cast

[Cyan4973]

Thanks, it's a straightforward and very useful patch for C++

[r-lyeh-archived]

👍 🍺