Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Conversation

dlespiau
Copy link
Member

Nothing too major found:

  • Errors weren't propagated in rpm.ToWFN
  • Some misspelled json struct tags
  • Some unused fields

I've disabled a few default linting passes, more notably errcheck: there are many code path where we don't check and propagate errors. This will have to be a task for another time.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 27, 2020
@dlespiau
Copy link
Member Author

Huum, we seem to be stumbling on golangci/golangci-lint#944

@dlespiau
Copy link
Member Author

A bit more information now:

could not load export data: cannot import "unicode/utf8" (unknown iexport format version 1), export data is newer version - update tool))

The go tools in master must have changed something in how they encode package export data in a way that the latest release of golangci-lint doesn't support yet.

I suggest to mark the master part of the testing matrix, the one testing go master, as not blocking.

@dlespiau dlespiau force-pushed the 2020-01-27-golangci-lint branch from 33ff69e to 1115597 Compare January 27, 2020 17:59
@skogtwin skogtwin merged commit fb7a240 into master Jan 27, 2020
@dlespiau dlespiau deleted the 2020-01-27-golangci-lint branch January 29, 2020 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants