[llvm] Fix invalid use of BitcodeWriter API. #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ChrisCummins
changed the title
Use the WriteBitcodeToFile() function rather than BitcodeWriter::writeMethod() method to prevent a debugging assertion. Issue facebookresearch#514.
ChrisCummins
force-pushed
the
bitcode-writer
branch
from
04d1ea0 to
085e79c
Compare
Codecov Report
@@ Coverage Diff @@
## development #515 +/- ##
===============================================
+ Coverage 87.44% 87.45% +0.01%
===============================================
Files 113 113
Lines 6403 6403
===============================================
+ Hits 5599 5600 +1
+ Misses 804 803 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
WriteBitcodeToFile()function rather thanBitcodeWriter::writeMethod()method to prevent a debugging assertion. Thanks @sogartar for reporting this.Fixes #514.