Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Enable capturing of comm collective parameters #98

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/torch_ucc_tracing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ void CommTraceLogger::recordComms(
",\n\t\t\"req\": ",
workReq,
",\n\t\t\"seqnum\": ",
seqnum++,
seqnum,
",\n\t\t\"world_size\": ",
world_size);

Expand Down Expand Up @@ -168,6 +168,8 @@ void CommTraceLogger::recordComms(

// record the trace to kineto trace if applicable
RECORD_PARAM_COMMS(
static_cast<int64_t>(seqnum), // seq
0, // process group ptr
rank,
commName.c_str(),
inSize,
Expand All @@ -176,6 +178,8 @@ void CommTraceLogger::recordComms(
curInSplitSizes_,
curOutSplitSizes_);

++seqnum;

// reset optional field
curRoot_ = -1;
curInSplitSizes_ = {};
Expand Down