Enable updating the password of a user. #107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pspoerri
commented
Feb 6, 2020
| @@ -24,6 +24,11 @@ def create(self, db_session: Session, *, obj_in: UserCreate) -> User: | |||
| db_session.refresh(db_obj) | |||
| return db_obj | |||
|
|
|||
| def update(self, db_session: Session, *, db_obj: ModelType, obj_in: UpdateSchemaType) -> ModelType: | |||
| if obj_in.password: | |||
| db_obj.hashed_password = get_password_hash(obj_in.password) | |||
There was a problem hiding this comment.
I am not sure if this is the correct place to update the password.
There was a problem hiding this comment.
You probably want to use the reset_password method in login.py
There was a problem hiding this comment.
You probably want to use the
reset_passwordmethod in login.py
Shouldn't it be the other way around, e.g. the endpoint/login.py using CRUDUser?
|
I was about to open almost the same PR to fix #109. I've put a small diff in there that you might want to add to your PR to fix the test as well :) |
|
Thanks for your contribution! 🚀 I think this was solved/included in #106 , right? |
|
Yes, looks like it. 😅 |
|
Thanks for reporting back and closing it 👍 |
alejsdev
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserUpdatedoes not have ahashed_password.