Skip to content

[Source Code]: move static imports to bottom #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
lucasstarsz opened this issue Nov 27, 2021 · 0 comments · Fixed by #160
Closed
1 task done

[Source Code]: move static imports to bottom #159

lucasstarsz opened this issue Nov 27, 2021 · 0 comments · Fixed by #160
Assignees
@lucasstarsz
Labels
source code Fix in FastJ's source code

Comments

@lucasstarsz
Copy link
Member

What's Up?

Like @teur mentioned, adding '\\#' to the end of importOrder arranges static imports to be placed last.

Originally posted by @yooksi in diffplug/spotless#306 (comment)

As shown above from diffplug/spotless#306, it's possible to configure static imports in spotless such that they are always on the bottom section of the imports. Let's move the static imports there.

Code of Conduct

  • I agree to follow FastJ's Code of Conduct
@lucasstarsz lucasstarsz added the source code Fix in FastJ's source code label Nov 27, 2021
@lucasstarsz lucasstarsz self-assigned this Nov 27, 2021
lucasstarsz added a commit that referenced this issue Nov 27, 2021
@lucasstarsz
(resolves #159) move static imports in spotlessApply to the bottom
ab50466
@lucasstarsz lucasstarsz mentioned this issue Nov 27, 2021
Merged
@lucasstarsz lucasstarsz changed the title [Source Code]: move static imports in spotlessApply to bottom of imports [Source Code]: move static imports to bottom Nov 27, 2021
@lucasstarsz lucasstarsz linked a pull request Nov 27, 2021 that will close this issue
(resolves #159) move static imports in Spotless to the bottom of the list #160
Merged
lucasstarsz added a commit that referenced this issue Nov 27, 2021
@lucasstarsz
(resolves #159) move static imports in spotlessApply to the bottom (#160
ffe51fd 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasstarsz lucasstarsz

Labels
source code Fix in FastJ's source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(resolves #159) move static imports in Spotless to the bottom of the list fastjengine/FastJ
1 participant
@lucasstarsz