Skip to content

Make the IServiceCollection work #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

davidfowl
Copy link
Collaborator

  • Eagerly evaluate callbacks that have to do with the services so that they are visible to the caller using WebApplicationBuilder.Services.

Fixes #35 and #36

- Eagerly evaluate callbacks that have to do with the services so that they are visible to the caller using WebApplicationBuilder.Services.
@davidfowl davidfowl force-pushed the davidfowl/service-collection-fixes branch from e6a6b30 to 0be478d Compare March 1, 2021 07:23
@davidfowl davidfowl merged commit 7c8518a into master Mar 1, 2021
@halter73
Copy link

halter73 commented Mar 1, 2021

Now that the IServiceCollection is populated earlier, can we get rid of _operations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Call to AddHttpClient() on WebApplicationBuilder.Services override serilog logging with default logging
2 participants