Node v8 stream destroy and _destroy methods

[mwiktorczyk]

Node v8 introduced some changes to stream API. One of them is destroy method:

• https://nodejs.org/api/stream.html#stream_readable_destroy_error
• https://nodejs.org/api/stream.html#stream_writable_destroy_error

According to this specification,

implementors should not override this method, but instead implement readable._destroy

Is there a chance to adapt your library to node v8 and later on fix the TypeScript definitions?

[t-mullen]

readable-stream doesn't seem to implement the same behaviour. (calling .destroy doesn't call the overridden ._destroy)

It seems it would be as simple as removing Peer.prototype.destroy if this was the case.

One thing to consider is that the Node V8 .destroy method isn't documented as having a callback parameter, but takes an error. We do the opposite: Peer.prototype.destroy(onclose)

https://nodejs.org/api/stream.html#stream_writable_destroy_error

[feross]

I think we can switch to the new interface and just shim the missing .destroy() method until this issue is fixed: nodejs/readable-stream#283

This is a breaking change since it changes the API, but it makes the API match Node.js which is aligns with user expectations and the stated goal of this package (to emulate net.Socket where possible).

PR here: #237