-
-
Notifications
You must be signed in to change notification settings - Fork 32
fix: migrate to streamx drop readable-stream #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
6f45129
to
33466aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should major version this change
I'm not certain this PR is correct fyi, as |
after testing, this is pretty much safe to merge, causes no issues anywhere |
webtorrent/webtorrent#1971
the echo server no longer exists, and no services like it exist, so instead we create a server ourselves.
streamx uses "objectMode" by default as it doesn't force Buffer, so I re-implemented forced buffer mode, encoding doesn't exist on streamx, so I changed the test to objectMode as it's pretty much the same result.