Skip to content

fix: migrate to streamx drop readable-stream #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ThaUnknown
Copy link

@ThaUnknown ThaUnknown commented Nov 3, 2022

webtorrent/webtorrent#1971

the echo server no longer exists, and no services like it exist, so instead we create a server ourselves.

streamx uses "objectMode" by default as it doesn't force Buffer, so I re-implemented forced buffer mode, encoding doesn't exist on streamx, so I changed the test to objectMode as it's pretty much the same result.

@socket-security
Copy link

socket-security bot commented Nov 3, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Network access ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected malware ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@ThaUnknown ThaUnknown force-pushed the streamx branch 3 times, most recently from 6f45129 to 33466aa Compare November 4, 2022 08:29
Copy link
Collaborator

@DiegoRBaquero DiegoRBaquero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should major version this change

@ThaUnknown
Copy link
Author

We should major version this change

I'm not certain this PR is correct fyi, as end might not fire on .destroy() with this? not 100% sure, asked mafintosh on feedback but he's ghosting too

@ThaUnknown
Copy link
Author

after testing, this is pretty much safe to merge, causes no issues anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants