Skip to content

Conversation

KikeSan
Copy link

@KikeSan KikeSan commented Oct 2, 2020

Footer proposal

@vercel
Copy link

vercel bot commented Oct 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fhrf/fhrfin/fl5vdw5vd
✅ Preview: https://fhrfin-git-f79a74fc9d74806057d2fb6ddbedc5e3f7fad84d.fhrf.vercel.app

@cTxplorer
Copy link
Collaborator

Hey, @KikeSan
This is awesome. I liked the use of different background color for the footer.

There's just one thing - the footer section should take up full width even when the sidebar is closed (on a smaller screen). Here's how it is looking in your case at the moment -
image

Did you notice that the sidebar menu toogler (on top right) is sliding up when we scroll beyond the main tag?

Do let me know if you face difficulty fixing it.

Thank you, again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants