Skip to content

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Sep 21, 2025

Proposed Changes

This PR updates Go version used in this repo to 1.24.7.

Additional Info

golangci-lint v1.64 is the last version in the v1 lineage. It has moved on to v2 now. v1.64 does not support Go 1.25 so we'll have to upgrade to v2 before we move on to Go 1.25 ourselves.

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 21, 2025
@galargh galargh requested review from BigLep and rvagg September 21, 2025 13:41
@galargh galargh marked this pull request as ready for review September 21, 2025 13:41
@galargh galargh changed the title Update Go to 1.24.7 chore!: upgrade to Go 1.24 Sep 21, 2025
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Sep 23, 2025
@rvagg
Copy link
Member

rvagg commented Sep 23, 2025

we might need to run a re-generate of the Go ffi types in here to see if there's any changes in 1.24? or do we have a CI run that does this for us?

@BigLep
Copy link
Member

BigLep commented Sep 24, 2025

@galargh : I assume you'll look at #545 (comment) and then merge when we're confirmed to be clear.

@galargh
Copy link
Contributor Author

galargh commented Sep 25, 2025

Right on, I'll get on it tomorrow!

@galargh
Copy link
Contributor Author

galargh commented Sep 27, 2025

@rvagg Could you point me in the direction of which types are generated here/how to regenerate them if needed? make still works both in the CI and on my local machine.

@BigLep
Copy link
Member

BigLep commented Sep 30, 2025

@rvagg Could you point me in the direction of which types are generated here/how to regenerate them if needed? make still works both in the CI and on my local machine.

@rjan90 : can you respond given Rod is out?

@rjan90
Copy link
Contributor

rjan90 commented Sep 30, 2025

As long as make succeeds, I think things should be good, since that rebuilds everything:

  • Builds the Rust library (which regenerates filcrypto.h)
  • Compiles the Go code with CGO

And I think if there were ype mismatches, the build or tests would fail.

@galargh
Copy link
Contributor Author

galargh commented Oct 2, 2025

In that case, I think we're good to go. OK if I merge this?

@rjan90
Copy link
Contributor

rjan90 commented Oct 2, 2025

Yes, go ahead and merge!

@galargh galargh merged commit cdd4358 into master Oct 2, 2025
5 checks passed
@galargh galargh deleted the go-1-24-7 branch October 2, 2025 14:35
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

4 participants