Selection rectangle overlays preview pane

[d2dyno1]

Describe the bug
Selection rectangle overlays preview pane

Expected behavior
Stop the rectangle at the preview pane's border

Screenshots

Additional context
This is a visual issue

[winston-de]

Likely related to #3004.

[nvi9]

Both this and #3004 could be solved with limiting the width and height of selectionRectangle in the DrawRectangle method (see below), but a cleaner solution would be better than checking bounds of the list view each time cursor moves...

Files/Files/UserControls/Selection/RectangleSelection.cs

Lines 71 to 112 in f86be9c

	protected void DrawRectangle(PointerPoint currentPoint, Point originDragPointShifted)
	{
	// Redraw selection rectangle according to the new point
	if (currentPoint.Position.X >= originDragPointShifted.X)
	{
	if (currentPoint.Position.Y <= originDragPointShifted.Y)
	{
	// Pointer was moved up and right
	Canvas.SetLeft(selectionRectangle, Math.Max(0, originDragPointShifted.X));
	Canvas.SetTop(selectionRectangle, Math.Max(0, currentPoint.Position.Y));
	selectionRectangle.Width = Math.Max(0, currentPoint.Position.X - Math.Max(0, originDragPointShifted.X));
	selectionRectangle.Height = Math.Max(0, originDragPointShifted.Y - Math.Max(0, currentPoint.Position.Y));
	}
	else
	{
	// Pointer was moved down and right
	Canvas.SetLeft(selectionRectangle, Math.Max(0, originDragPointShifted.X));
	Canvas.SetTop(selectionRectangle, Math.Max(0, originDragPointShifted.Y));
	selectionRectangle.Width = Math.Max(0, currentPoint.Position.X - Math.Max(0, originDragPointShifted.X));
	selectionRectangle.Height = Math.Max(0, currentPoint.Position.Y - Math.Max(0, originDragPointShifted.Y));
	}
	}
	else
	{
	if (currentPoint.Position.Y <= originDragPointShifted.Y)
	{
	// Pointer was moved up and left
	Canvas.SetLeft(selectionRectangle, Math.Max(0, currentPoint.Position.X));
	Canvas.SetTop(selectionRectangle, Math.Max(0, currentPoint.Position.Y));
	selectionRectangle.Width = Math.Max(0, originDragPointShifted.X - Math.Max(0, currentPoint.Position.X));
	selectionRectangle.Height = Math.Max(0, originDragPointShifted.Y - Math.Max(0, currentPoint.Position.Y));
	}
	else
	{
	// Pointer was moved down and left
	Canvas.SetLeft(selectionRectangle, Math.Max(0, currentPoint.Position.X));
	Canvas.SetTop(selectionRectangle, Math.Max(0, originDragPointShifted.Y));
	selectionRectangle.Width = Math.Max(0, originDragPointShifted.X - Math.Max(0, currentPoint.Position.X));
	selectionRectangle.Height = Math.Max(0, currentPoint.Position.Y - Math.Max(0, originDragPointShifted.Y));
	}
	}
	}

[nvi9]

Yesterday I've made some trials with this proposal, it only helped with the horizontal limiting issue (this one), but not with the other in case of a view with scrolling content (when the items overflow and the selection rectangle is visible during scrolling up). So (this time) I think it would be better to try to solve them independently 😅 this one from the C# side, the other one from the XAML side with making the statusbar completely hide the selection rectangle on the bottom side too.

I'll make a PR for this one in the next days if it's okay to you. And maybe to the other one too if I find something usable.

[yaira2]

@d2dyno1 This issue should be resolved with #3520.