Skip to content

Fix: Fixed issue where content on the search results page wasn't centered #10570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 17, 2023
Merged

Fix: Fixed issue where content on the search results page wasn't centered #10570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
25c0bbc
bug-10549: Hide search non-indexed objects
itayweb Nov 26, 2022
a4ef393
bug-10549: Center text and button
itayweb Dec 3, 2022
8bb3f2b
bug-10549: Fix indent
itayweb Dec 10, 2022
6366eef
bug-10549: Another fix of indent
itayweb Dec 12, 2022
91c754d
Merge branch 'main' into bug-10549
QuaintMako Dec 14, 2022
726351c
Revert "bug-10549: Another fix of indent"
QuaintMako Dec 14, 2022
ff8fc26
Fixing indentation
QuaintMako Dec 14, 2022
7dab4ce
Merge branch 'main' into bug-10549
QuaintMako Jan 16, 2023
15b9c1d
Merge branch 'main' into bug-10549
QuaintMako Jan 16, 2023
329c016
Removed border controler
QuaintMako Jan 16, 2023
37cc19b
Centering button for search
QuaintMako Jan 16, 2023
2b6984b
Merge branch 'main' into bug-10549
yaira2 Jan 16, 2023
d2612a1
Merge branch 'main' into bug-10549
QuaintMako Jan 17, 2023
0072798
Removing dot at end of sentence
QuaintMako Jan 17, 2023
b5b5aa9
Update src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml
yaira2 Jan 17, 2023
b62e24a
Update src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml
yaira2 Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Files.App/Strings/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1645,7 +1645,7 @@
<value>Didn't find what you're looking for?</value>
</data>
<data name="SearchUnindexedItemsButton.Content" xml:space="preserve">
<value>Search unindexed items.</value>
<value>Search unindexed items</value>
</data>
<data name="SettingsAppearanceOpenThemesFolderButton.Content" xml:space="preserve">
<value>Open themes folder</value>
Expand Down
28 changes: 14 additions & 14 deletions src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,20 @@
Canvas.ZIndex="0"
EmptyTextType="{x:Bind ParentShellPageInstance.FilesystemViewModel.EmptyTextType, Mode=OneWay}" />

<StackPanel
x:Name="SearchUnindexedItemsPanel"
HorizontalAlignment="Center"
VerticalAlignment="Bottom"
x:Load="{x:Bind InstanceViewModel.ShowSearchUnindexedItemsMessage, Mode=OneWay}"
Orientation="Vertical">
<TextBlock Text="{helpers:ResourceString Name=SearchUnindexedItemsLabel/Text}" />
<HyperlinkButton
x:Name="SearchUnindexedItemsButton"
HorizontalAlignment="Center"
Command="{x:Bind CommandsViewModel.SearchUnindexedItems}"
Content="{helpers:ResourceString Name=SearchUnindexedItemsButton/Content}" />
</StackPanel>

<TeachingTip
x:Name="FileNameTeachingTip"
CloseButtonContent="{helpers:ResourceString Name=FileNameTeachingTip/CloseButtonContent}"
Expand Down Expand Up @@ -877,20 +891,6 @@
<ItemsStackPanel AreStickyGroupHeadersEnabled="False" Orientation="Vertical" />
</ItemsPanelTemplate>
</ListView.ItemsPanel>
<ListView.Footer>
<StackPanel
x:Name="SearchUnindexedItemsPanel"
HorizontalAlignment="Stretch"
x:Load="{x:Bind InstanceViewModel.ShowSearchUnindexedItemsMessage, Mode=OneWay}"
Orientation="Vertical">
<TextBlock HorizontalTextAlignment="Center" Text="{helpers:ResourceString Name=SearchUnindexedItemsLabel/Text}" />
<HyperlinkButton
x:Name="SearchUnindexedItemsButton"
HorizontalAlignment="Center"
Command="{x:Bind CommandsViewModel.SearchUnindexedItems}"
Content="{helpers:ResourceString Name=SearchUnindexedItemsButton/Content}" />
</StackPanel>
</ListView.Footer>
</ListView>
</SemanticZoom.ZoomedInView>

Expand Down