Skip to content

Feature: Show size when hovering over recycling bin #10904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jan 9, 2023
Merged

Feature: Show size when hovering over recycling bin #10904

merged 32 commits into from
Jan 9, 2023

Conversation

hecksmosis
Copy link
Contributor

@hecksmosis hecksmosis commented Jan 2, 2023 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
image

@hecksmosis hecksmosis changed the title Recyclebinsize Feature: Show recycle bin size in sidebar tooltip Jan 2, 2023
@QuaintMako
Copy link
Contributor

Can we get a screenshot of the result?

@hecksmosis
Copy link
Contributor Author

I'm not very good at UI so it'll probably need some changes

@jiejasonliu
Copy link
Contributor

we have existing FileWatcher(s) on the recycle bin, would it be better to update the size whenever a change occurs there?
it avoids the overhead of manually calling refresh everywhere as well as synchronizing with outside changes to the bin

@hecksmosis
Copy link
Contributor Author

Yes, I didn't notice that

@yaira2
Copy link
Member

yaira2 commented Jan 2, 2023

Spacing looks messed up, can you review?

@hecksmosis
Copy link
Contributor Author

Is it good now?

yaira2
yaira2 reviewed Jan 2, 2023
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented Jan 2, 2023

I believe there is already property to change the sidebar tooltip text, I don't think you need to make any changes to the xaml.

@hecksmosis
Copy link
Contributor Author

Done

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jan 2, 2023
jiejasonliu
jiejasonliu reviewed Jan 2, 2023
View reviewed changes
QuaintMako
QuaintMako reviewed Jan 2, 2023
View reviewed changes
QuaintMako
QuaintMako reviewed Jan 4, 2023
View reviewed changes
QuaintMako
QuaintMako previously approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

gave92
gave92 previously approved these changes Jan 8, 2023
View reviewed changes
gave92
gave92 previously approved these changes Jan 8, 2023
View reviewed changes
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jan 9, 2023
@yaira2 yaira2 merged commit 6b6fb1a into files-community:main Jan 9, 2023
@yaira2 yaira2 changed the title Feature: Show recycle bin size in sidebar tooltip Feature: Show size when hovering recycling bin Jan 9, 2023
@yaira2 yaira2 changed the title Feature: Show size when hovering recycling bin Feature: Show size when hovering over recycling bin Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

+3 more reviewers

@jiejasonliu jiejasonliu jiejasonliu left review comments

@QuaintMako QuaintMako QuaintMako left review comments

@gave92 gave92 gave92 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hecksmosis @QuaintMako @jiejasonliu @yaira2 @gave92