Skip to content

Fix: Don't show Pin/Unpin for items in recycle bin #10945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 11, 2023
Merged

Fix: Don't show Pin/Unpin for items in recycle bin #10945

merged 9 commits into from
Jan 11, 2023

Conversation

Hark64
Copy link
Contributor

@Hark64 Hark64 commented Jan 7, 2023 •
edited by yaira2
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.
-Related to #10921

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@Hark64 Hark64 mentioned this pull request Jan 7, 2023
Merged
2 tasks
@QuaintMako QuaintMako changed the title FIx for PR #10921 Fix: Not showing Pin/Unpin Item for start menu in selection Jan 7, 2023
QuaintMako
QuaintMako suggested changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hark64 I believe the work done here is not on the up to date main branch. PR #10921 has already been merged. Instead of adding back l.559 and l.569, you should remove l.986 and l.998 after rebasing your branch with main.

@Hark64
Copy link
Contributor Author

Hark64 commented Jan 8, 2023

Sorry I'm a little confused. I thought I did remove l.986 and l.998 here.

@gave92 gave92 requested a review from QuaintMako January 8, 2023 16:37
QuaintMako
QuaintMako approved these changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gave92 gave92 added the ready to merge Pull requests that are approved and ready to merge label Jan 10, 2023
@yaira2 yaira2 changed the title Fix: Not showing Pin/Unpin Item for start menu in selection Fix: Don't show Pin/Unpin Item for items in recycle bin Jan 11, 2023
@yaira2 yaira2 changed the title Fix: Don't show Pin/Unpin Item for items in recycle bin Fix: Don't show Pin/Unpin for items in recycle bin Jan 11, 2023
@yaira2 yaira2 merged commit 829b5bb into files-community:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@gave92 gave92 gave92 approved these changes

@QuaintMako QuaintMako QuaintMako approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hark64 @gave92 @QuaintMako @yaira2