Skip to content

Fixed: DetailsLayout Margin/Padding is not set correctly #11198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fixed: DetailsLayout Margin/Padding is not set correctly #11198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Files.App/ViewModels/ColumnsViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ public GridLength Length
get => IsHidden || UserCollapsed ? new GridLength(0) : UserLength;
}

private const int gridSplitterWidth = 8;
private const int gridSplitterWidth = 12;

[LiteDB.BsonIgnore]
public GridLength LengthIncludingGridSplitter
Expand Down
8 changes: 5 additions & 3 deletions src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@

<Grid
x:Name="ItemTagGrid"
Width="{Binding ColumnsViewModel.TagColumn.Length.Value, ElementName=PageRoot, Mode=OneWay}"
Width="{Binding ColumnsViewModel.TagColumn.LengthIncludingGridSplitter.Value, ElementName=PageRoot, Mode=OneWay}"
HorizontalAlignment="Stretch"
VerticalAlignment="Center"
Visibility="{Binding ColumnsViewModel.TagColumn.Visibility, ElementName=PageRoot, Mode=OneWay}">
Expand Down Expand Up @@ -705,7 +705,8 @@
VerticalAlignment="Center"
x:Load="{x:Bind IsRecycleBinItem}"
Style="{StaticResource ColumnContentTextBlock}"
Text="{x:Bind AsRecycleBinItem.ItemOriginalPath, Mode=OneWay}" />
Text="{x:Bind AsRecycleBinItem.ItemOriginalPath, Mode=OneWay}"
Visibility="{Binding ColumnsViewModel.OriginalPathColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />

<TextBlock
x:Name="ItemDateDeleted"
Expand All @@ -715,7 +716,8 @@
VerticalAlignment="Center"
x:Load="{x:Bind IsRecycleBinItem}"
Style="{StaticResource ColumnContentTextBlock}"
Text="{x:Bind AsRecycleBinItem.ItemDateDeleted, Mode=OneWay}" />
Text="{x:Bind AsRecycleBinItem.ItemDateDeleted, Mode=OneWay}"
Visibility="{Binding ColumnsViewModel.DateDeletedColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />

<TextBlock
x:Name="ItemDateModified"
Expand Down