Skip to content

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Feb 19, 2023

Can you do this with BaseLayout as well?

@hecksmosis
Copy link
Contributor Author

Can you do this with BaseLayout as well?

When would this be used?

@yaira2
Copy link
Member

yaira2 commented Feb 19, 2023

When right clicking a blank space

@hecksmosis
Copy link
Contributor Author

Ok

@hecksmosis
Copy link
Contributor Author

Done

yaira2
yaira2 previously approved these changes Feb 20, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Feature: Move format drive to main context menu Feature: Moved "format drive" to main context menu Feb 20, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 20, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 20, 2023

Does right clicking a sub folder in c:\ crash the app for you?

@yaira2
Copy link
Member

yaira2 commented Feb 21, 2023

The crash is fixed but the menu doesn't load when right clicking a selected folder.

@hecksmosis
Copy link
Contributor Author

Yes, I know, this is because of an bug in a merge in #11365 with #11357

@hecksmosis
Copy link
Contributor Author

Fixed

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

When right clicking a blank space

I just checked and this is actually not a valid use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Option to format drives should be displayed in the main menu

2 participants