Skip to content

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 1, 2023

Description

I'm adding hash page to storage object's properties window.

Motivation and Context

Validation

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots

Loading
image

Left: Managed to load, Right: Failed to load
image

@yaira2 yaira2 changed the title Feature: Introduce Hash page Feature: Added hashes tab to properties window Mar 1, 2023
@0x5bfa 0x5bfa marked this pull request as ready for review March 2, 2023 17:07
@yaira2
Copy link
Member

yaira2 commented Mar 2, 2023

Clicking the hashes page for large files causes the properties window to freeze.

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 4, 2023

Ready to review.

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little thing, otherwise LGTM and works for me

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 6, 2023

I cannot fix an issue where Files will freeze as loading a large file(1 GiB or more).

  • CancellationToken doesn't work
  • DispatcherQueue doesn't work
  • ICommand doesn't work

await is bad? maybe Task.Run()?

@hishitetsu
Copy link
Member

How about using HashDataAsync()? It accepts CancellationToken.
https://learn.microsoft.com/en-us/dotnet/api/system.security.cryptography.sha512.hashdataasync?view=net-7.0

@mdtauk
Copy link
Contributor

mdtauk commented Mar 8, 2023

I cannot fix an issue where Files will freeze as loading a large file(1 GiB or more).

  • CancellationToken doesn't work
  • DispatcherQueue doesn't work
  • ICommand doesn't work

await is bad? maybe Task.Run()?

Have you included a progress ring or progress bar as the hashes are being calculated?

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 8, 2023

@yaira2 Tried new one. Can you check also? Works fine for me.

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Mar 8, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 8, 2023

Have you included a progress ring or progress bar as the hashes are being calculated?

@mdtauk there is a progress ring 👍

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit dbe3202 into files-community:main Mar 8, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Mar 8, 2023
@0x5bfa 0x5bfa deleted the 5bfa/introduce-hashprops branch March 26, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add hashes tab to the properties window

5 participants