Skip to content

Fix: Update thumbnail when rotating image #11635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 12, 2023
Merged

Fix: Update thumbnail when rotating image #11635

merged 6 commits into from
Mar 12, 2023

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

Screenshots
rotation

@QuaintMako
Copy link
Contributor Author

Any idea of manipulation that would require a refresh of the selected icons I could try to ensure everything works as expected?

@yaira2 yaira2 requested a review from gave92 March 9, 2023 15:26
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Mar 9, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 9, 2023

Any idea of manipulation that would require a refresh of the selected icons I could try to ensure everything works as expected?

  1. Changing a folders thumbnail

@QuaintMako
Copy link
Contributor Author

  1. Changing a folders thumbnail

Works as expected.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Mar 12, 2023
yaira2
yaira2 approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Refreshing selected items icons now done for all layouts Fix: Update thumbnail when rotating image Mar 12, 2023
@yaira2 yaira2 merged commit 75ea0be into files-community:main Mar 12, 2023
@QuaintMako QuaintMako deleted the RefreshIcons branch March 22, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@gave92 gave92 Awaiting requested review from gave92

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Rotate Image does not refresh icon thumbnail
2 participants
@QuaintMako @yaira2