Skip to content

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. See it still works

Screenshots (optional)
Add screenshots here.

@hecksmosis hecksmosis changed the base branch from main to 2.4.60-servicing April 2, 2023 12:16
@lukeblevins lukeblevins mentioned this pull request Apr 2, 2023
8 tasks
@lukeblevins
Copy link
Contributor

Hey @hecksmosis,

I went ahead and incorporated the logging changes from this PR into my branch that has larger changes here: #11937

Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment below 👍🏻

@hecksmosis
Copy link
Contributor Author

Ok, so should I close this?

@yaira2
Copy link
Member

yaira2 commented Apr 2, 2023

Ok, so should I close this?

We can keep it open, I want to include this in the next servicing release.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit df66c45 into files-community:2.4.60-servicing Apr 2, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: DetectQuickLookAvailability|QuickLook detected: False spammed in log file
5 participants