Skip to content

Code Quality: Merged App.ValueConverters with App.Converters #12235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 1, 2023
Merged

Code Quality: Merged App.ValueConverters with App.Converters #12235

merged 5 commits into from
May 1, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 29, 2023 •
edited
Loading

Code Quality: Merged App.ValueConverters with App.Converters

Motivation and Context

Unneeded duplication.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 29, 2023

Ready for review.

ferrariofilippo
ferrariofilippo reviewed Apr 29, 2023
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be ok, but I left a comment

@0x5bfa
Copy link
Member Author

0x5bfa commented May 1, 2023

@yaira2 @ferrariofilippo can you review?

ferrariofilippo
ferrariofilippo approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaira2 yaira2 requested a review from hez2010 May 1, 2023 16:37
yaira2
yaira2 approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

@yaira2 yaira2 merged commit bf1e40a into files-community:main May 1, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 1, 2023
@0x5bfa 0x5bfa deleted the 5bfa/merge-valueconvandconv branch May 9, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

@hez2010 hez2010 Awaiting requested review from hez2010

+1 more reviewer

@ferrariofilippo ferrariofilippo ferrariofilippo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0x5bfa @hez2010 @yaira2 @ferrariofilippo