Skip to content

Code Quality: Improved Omnibar 4 #17189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 19, 2025
Merged

Code Quality: Improved Omnibar 4 #17189

merged 6 commits into from
Jun 19, 2025

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jun 13, 2025 •
edited by yaira2
Loading

Resolved / Related Issues

  • Feature: Omnibar #16029
  • Switching tabs while focused on the Omnibar causes a crash
  • Tab navigation isn't properly focusing on the Breadcrumb Bar
  • Mode icons aren't updating when switching themes
  • On a fresh start, focusing on the Path Mode textbox doesn't open the suggestion flyout
  • Chevrons are disappearing after adding a new tab
  • Text isn't selected when focusing on path mode
  • The 'no results' item isn't showing when there are no results
  • Command flyout doesn't contain any items when switching from path mode to command mode
  • Switching between path mode and command mode a couple of times causes crash

Steps used to test these changes

Coming soon.

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarUX3 branch from 8d60429 to 6485531 Compare June 16, 2025 15:24
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarUX3 branch from 73bde04 to 3e169ba Compare June 16, 2025 16:40
yaira2
yaira2 approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 19, 2025
@yaira2 yaira2 marked this pull request as ready for review June 19, 2025 15:26
@yaira2 yaira2 merged commit c26f472 into files-community:main Jun 19, 2025
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-OmnibarUX3 branch June 19, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x5bfa @yaira2