Skip to content

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Oct 27, 2020

Fixes #1492
Fixes #873

@yaira2
Copy link
Member

yaira2 commented Oct 27, 2020

Can you check if this causes the event to be fired twice?

@Thomas1664
Copy link
Contributor Author

Can you check if this causes the event to be fired twice?

The event is only invoked once either using keyboard shortcut or the actual menu item

@yaira2 yaira2 requested a review from tsvietOK October 27, 2020 22:59
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Oct 30, 2020
@Thomas1664 Thomas1664 requested a review from tsvietOK November 15, 2020 21:29
Copy link
Contributor

@tsvietOK tsvietOK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Can't rename file in GridView mode.
Steps:

  1. Select file and press F2.
  2. Click on empty space or press Enter.
  3. Crash

@Thomas1664
Copy link
Contributor Author

@tsvietOK This issue occurs on master as well.
More precise steps to reproduce:

  1. Switch to grid view
  2. Select an item
  3. Press F2 to rename
  4. Rename the item
  5. Switch to tiles view
  6. Rename the same item again by selecting it and pressing F2
  7. Switch back to grid view
  8. Select the same item
  9. Press F2 to rename
  10. See error

@tsvietOK
Copy link
Contributor

Can't reproduce your issue.

@Thomas1664
Copy link
Contributor Author

@tsvietOK If you referred to a dialog box popping up saying that you can't have 2 files with the same name, this appears in master as well.

@tsvietOK
Copy link
Contributor

No, i can't reproduce your issue at all. I am able to rename files without any problem on master branch.

@tsvietOK
Copy link
Contributor

Issue i mentioned before still exists with your changes.

@Thomas1664
Copy link
Contributor Author

@tsvietOK And I can't reproduce any issue you have.

@Thomas1664
Copy link
Contributor Author

@tsvietOK This commit might fix your issue (at least it fixes mine)

@tsvietOK
Copy link
Contributor

Issue reported by me still present.

@Thomas1664
Copy link
Contributor Author

I still have no crash. How should we continue since I can't reproduce your crash after renaming a file?

@tsvietOK
Copy link
Contributor

tsvietOK commented Nov 16, 2020

bug
image

@tsvietOK
Copy link
Contributor

tsvietOK commented Nov 16, 2020

image
This is due to the double call of the event.

@Thomas1664 Thomas1664 requested a review from tsvietOK November 16, 2020 22:54
@ItsNightWolf

This comment has been minimized.

@Thomas1664
Copy link
Contributor Author

Hey, how are you? I a new at this whole coding business. . . But was wondering, is there a way to set "Files - preview" as the default file explorer? And how can I change the icon, as I was able to do it with all my other apps by using properties but it doesn't seem to work with yours. . . Thanks so much and keep it up!

@coheneli98 Please don't ask questions like this in PRs. File an issue or use Discord instead!

@tsvietOK
Copy link
Contributor

Can't delete file.
Steps:

  1. Open GridView mode
  2. Select file
  3. Press Delete button
  4. Crash

@tsvietOK
Copy link
Contributor

tsvietOK commented Nov 16, 2020

Now Delete button is not working in ListView mode.

@Thomas1664
Copy link
Contributor Author

@tsvietOK I can't reproduce a bug with the delete item in context menu. A screenshot would be helpful.

@tsvietOK
Copy link
Contributor

I am talking about Delete button on your keyboard.

@tsvietOK
Copy link
Contributor

When paste file it shows several copies of these files(PasteItem() called twice), but it fixes when pressing F5.

@Thomas1664
Copy link
Contributor Author

@tsvietOK Please check if there are any other issues in this PR so I can fix them all at once.

@tsvietOK
Copy link
Contributor

@Thomas1664 Sure

@tsvietOK
Copy link
Contributor

tsvietOK commented Nov 17, 2020

"Cut item" called twice.

@tsvietOK
Copy link
Contributor

"Copy item" called twice.

@yaira2 yaira2 requested a review from gave92 November 17, 2020 20:38
tsvietOK
tsvietOK previously approved these changes Nov 17, 2020
@tsvietOK tsvietOK requested a review from yaira2 November 17, 2020 20:58
@yaira2 yaira2 changed the title Display available keyboard shortcuts in flyouts Display available keyboard shortcuts in context menus Nov 17, 2020
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Nov 17, 2020
@yaira2 yaira2 merged commit dbbb002 into files-community:master Nov 17, 2020
@Thomas1664 Thomas1664 deleted the keyboard-accelerators branch November 17, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts on context menus

4 participants