-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Display available keyboard shortcuts in context menus #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display available keyboard shortcuts in context menus #2163
Conversation
Can you check if this causes the event to be fired twice? |
The event is only invoked once either using keyboard shortcut or the actual menu item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Can't rename file in GridView mode.
Steps:
- Select file and press F2.
- Click on empty space or press Enter.
- Crash
@tsvietOK This issue occurs on master as well.
|
Can't reproduce your issue. |
@tsvietOK If you referred to a dialog box popping up saying that you can't have 2 files with the same name, this appears in master as well. |
No, i can't reproduce your issue at all. I am able to rename files without any problem on master branch. |
Issue i mentioned before still exists with your changes. |
@tsvietOK And I can't reproduce any issue you have. |
@tsvietOK This commit might fix your issue (at least it fixes mine) |
…sions is disabled
Issue reported by me still present. |
I still have no crash. How should we continue since I can't reproduce your crash after renaming a file? |
This comment has been minimized.
This comment has been minimized.
@coheneli98 Please don't ask questions like this in PRs. File an issue or use Discord instead! |
Can't delete file.
|
Now Delete button is not working in ListView mode. |
@tsvietOK I can't reproduce a bug with the delete item in context menu. A screenshot would be helpful. |
I am talking about Delete button on your keyboard. |
When paste file it shows several copies of these files(PasteItem() called twice), but it fixes when pressing F5. |
@tsvietOK Please check if there are any other issues in this PR so I can fix them all at once. |
@Thomas1664 Sure |
"Cut item" called twice. |
"Copy item" called twice. |
Fixes #1492
Fixes #873