Fixed an issue that would occur when network drives were disconnected #2205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
yaira2
approved these changes
Nov 2, 2020
lukeblevins
pushed a commit
that referenced
this pull request
Nov 3, 2020
* Update translation (#2178) * Use GetLocalized string extension from Windows Community Toolkit (#2180) * Added an option to reorder pinned items in the sidebar (#2116) Co-authored-by: Yair Aichenbaum <[email protected]> * Fixed an issue where the 'Empty Recycle Bin' context menu was always grayed out (#2191) * Updated the font size and opacity for the recent items widget (#2193) * [#2190] - Checked for UnauthorizedAccessException on a selected directory (#2197) * Update Files.hu-HU.xlf (#2200) * Fixed a couple issues in ItemViewModel (#2189) * Added a drives widget (#2196) Co-authored-by: Marco Gavelli <[email protected]> * Fixed an issue that would occur when network drives were disconnected (#2205) * Updated the sidebar styles (#2209) * Translation update [es-ES] (#2211) * Added support for ARM64 devices (#2219) * Added animations to the widgets (#2213) Co-authored-by: Jaiganesh Kumaran <[email protected]> Co-authored-by: DanielSlincak <[email protected]> Co-authored-by: Yair Aichenbaum <[email protected]> Co-authored-by: igoragm <[email protected]> Co-authored-by: Kristóf Kékesi <[email protected]> Co-authored-by: Richard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2174
This PR solves the issue of app hanging on start if a network drive is disconnected.
This is done by:
EnumerateItemsFromStandardFolderafter which a "Drive disconnected" dialog is shown -> fix hang is the user navigates to a disconnected drive