Added a right click context menu to the horizontal tab control

[yaira2]

Part of #260.

[d2dyno1]

Looks good 👍

[gave92]

This adds a new tab at the end of the tab row right?
Would be nice if it added the new tab right next to the clicked tab

[yaira2]

This adds a new tab at the end of the tab row right?
Would be nice if it added the new tab right next to the clicked tab

That would be a nice enhancement, do you have any ideas how we can find out which tab was right clicked on?

[gave92]

@yaichenbaum The following should do the job

private async void NewTabMenuItem_Click(object sender, RoutedEventArgs e)
{
    var tabItem = ((FrameworkElement)sender).DataContext as TabItem;
    var index = MainPage.AppInstances.IndexOf(tabItem);
    await MainPage.AddNewTabByPathAsync(typeof(ModernShellPage), "NewTab".GetLocalized(), index + 1);
}

!EDIT!
This will easily trigger an (existing) bug that makes the app crash, to reproduce:

1. right click on the first tab and select "add new tab"
2. right click on the first tab and select "add new tab" (again)
3. navigate to a folder
4. crash with NullReferenceException in SetSelectedTabInfoAsync

[gave92]

New options work fine but I can still repro the bug described above with the "new tab" menu item

[yaira2]

This will easily trigger an (existing) bug that makes the app crash, to reproduce:

@gave92 I removed the part that inserts the tab next to the one that was right clicked. This should solve the issue while we continue to look for a better solution.