Fixed an issue where the text in the properties dialog would get cut off in some languages

[yaira2]

• Fixed an issue where the text in the properties dialog would get cut off in some languages.
• Changed the "ok" button in the properties dialog to "apply"

Fixes #2410

[d2dyno1]

"Apply" is inconsistent with Windows design guidelines

[yaira2]

"Apply" is inconsistent with Windows design guidlines

Do you have a link?

[d2dyno1]

@yaichenbaum #1838 (#1851)

[yaira2]

@yaichenbaum #1838 (#1851)

Do you have any links regarding the guidelines? The links you shared are regarding the order, not the text.

[d2dyno1]

https://docs.microsoft.com/en-us/windows/win32/uxguide/win-property-win#commit-buttons

OK buttons
For owner property windows, the OK button means apply the pending changes (made since the window was opened or the last Apply), and close the window

Apply buttons
For owner property sheets, the Apply button means apply the pending changes (made since the window was opened or the last Apply), but leave the window open

If we want to keep the Apply button, it must not close the window, it should only save the changes.

[yaira2]

https://docs.microsoft.com/en-us/windows/win32/uxguide/win-property-win#guidelines

OK buttons
For owner property windows, the OK button means apply the pending changes (made since the window was opened or the last Apply), and close the window

Apply buttons
For owner property sheets, the Apply button means apply the pending changes (made since the window was opened or the last Apply), but leave the window open

If we want to keep the Apply button, it must not close the window, it should only save the changes.

That's a good point, we should probably have all three buttons.

[lukeblevins]

changes LGTM