Skip to content

Drive Widget details are now hidden when they are not available #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 25, 2020
Merged

Drive Widget details are now hidden when they are not available #2704

merged 5 commits into from
Dec 25, 2020

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Dec 25, 2020

BEFORE:
image

AFTER:
image

yaira2
yaira2 previously approved these changes Dec 25, 2020
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented Dec 25, 2020

:shipit:

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 25, 2020
@d2dyno1
Copy link
Member Author

d2dyno1 commented Dec 25, 2020 •
edited
Loading

With RowSpacing, the text is not centered:

With RowSpacing:
image

Without RowSpacing:
image

@yaichenbaum

@files-community files-community deleted a comment from d2dyno1 Dec 25, 2020
@files-community files-community deleted a comment from d2dyno1 Dec 25, 2020
@d2dyno1
Copy link
Member Author

d2dyno1 commented Dec 25, 2020 •
edited
Loading

Should I replace Spacing with Margin?

@yaichenbaum

@yaira2
Copy link
Member

yaira2 commented Dec 25, 2020

Should I replace Spacing with Margin?

@yaichenbaum

Yes.

@d2dyno1
Copy link
Member Author

d2dyno1 commented Dec 25, 2020

Merge issues 💁‍♂️

@d2dyno1
Copy link
Member Author

d2dyno1 commented Dec 25, 2020

:shipit:

@yaira2 yaira2 changed the title Hidden Drive Widget details when they cannot be provided Drive Widget details are now hidden when they are not available Dec 25, 2020
@yaira2 yaira2 merged commit 8006382 into files-community:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d2dyno1 @yaira2