Significantly improve overall performance and UI responsiveness

Files/BaseLayout.cs

@@ -365,7 +365,7 @@ protected override async void OnNavigatedTo(NavigationEventArgs eventArgs)
                 ParentShellPageInstance.InstanceViewModel.IsPageTypeSearchResults = true;
                 if (!navigationArguments.IsLayoutSwitch)
                 {
-                    ParentShellPageInstance.FilesystemViewModel.AddSearchResultsToCollection(navigationArguments.SearchResults, navigationArguments.SearchPathParam);
+                    await ParentShellPageInstance.FilesystemViewModel.AddSearchResultsToCollection(navigationArguments.SearchResults, navigationArguments.SearchPathParam);
                 }
             }
 
@@ -751,12 +751,12 @@ public void RightClickItemContextMenu_Opening(object sender, object e)
             ParentShellPageInstance.ContentPage.SelectedItemsPropertiesViewModel.CheckFileExtension();
         }
 
-        protected virtual void Page_CharacterReceived(CoreWindow sender, CharacterReceivedEventArgs args)
+        protected virtual async void Page_CharacterReceived(CoreWindow sender, CharacterReceivedEventArgs args)
         {
             if (ParentShellPageInstance.IsCurrentInstance)
             {
                 char letterPressed = Convert.ToChar(args.KeyCode);
-                ParentShellPageInstance.InteractionOperations.PushJumpChar(letterPressed);
+                await ParentShellPageInstance.InteractionOperations.PushJumpChar(letterPressed);
             }
         }
 

Files/Files.csproj

@@ -185,10 +185,12 @@
     <Compile Include="Dialogs\RestartDialog.xaml.cs">
       <DependentUpon>RestartDialog.xaml</DependentUpon>
     </Compile>
+    <Compile Include="Helpers\BitmapHelper.cs" />
     <Compile Include="Helpers\FileListCache\CacheEntry.cs" />
     <Compile Include="Helpers\FileListCache\FileListCacheController.cs" />
     <Compile Include="Helpers\FileListCache\IFileListCache.cs" />
     <Compile Include="Helpers\FileListCache\PersistentSQLiteCacheAdapter.cs" />
+    <Compile Include="Helpers\IntervalSampler.cs" />
     <Compile Include="Helpers\RegistryHelper.cs" />
     <Compile Include="UserControls\MultitaskingControl\TabItem\TabItemControl.xaml.cs">
       <DependentUpon>TabItemControl.xaml</DependentUpon>

Files/Filesystem/Cloud/Providers/AmazonDriveProvider.cs

@@ -12,25 +12,27 @@ public class AmazonDriveProvider : ICloudProviderDetector
     {
         public async Task DetectAsync(List<CloudProvider> cloudProviders)
         {
-            try
+            await Task.Run(() =>
             {
-                await Task.Run(() =>
+                try
                 {
                     using var key = Registry.ClassesRoot.OpenSubKey(@"CLSID\{9B57F475-CCB0-4C85-88A9-2AA9A6C0809A}\Instance\InitPropertyBag");
-                    var syncedFolder = (string)key.GetValue("TargetFolderPath");
+                    var syncedFolder = (string)key?.GetValue("TargetFolderPath");
+
+                    if (syncedFolder == null) return;
 
                     cloudProviders.Add(new CloudProvider()
                     {
                         ID = CloudProviders.AmazonDrive,
                         Name = "Amazon Drive",
                         SyncFolder = syncedFolder
                     });
-                });
-            }
-            catch
-            {
-                // Not detected
-            }
+                }
+                catch
+                {
+                    // Not detected
+                }
+            });
         }
     }
 }

Files/Helpers/BitmapHelper.cs

@@ -0,0 +1,19 @@
+using System;
+using System.IO;
+using System.Threading.Tasks;
+using Windows.UI.Xaml.Media.Imaging;
+
+namespace Files.Helpers
+{
+    static class BitmapHelper
+    {
+        public static async Task<BitmapImage> ToBitmapAsync(this byte[] data)
+        {
+            if (data is null) return null;
+            using var ms = new MemoryStream(data);
+            var image = new BitmapImage();
+            await image.SetSourceAsync(ms.AsRandomAccessStream());
+            return image;
+        }
+    }
+}

Files/Helpers/FileListCache/FileListCacheController.cs

@@ -1,4 +1,5 @@
 using Microsoft.Extensions.Caching.Memory;
+using System.Threading;
 using System.Threading.Tasks;
 
 namespace Files.Helpers.FileListCache
@@ -27,21 +28,36 @@ private FileListCacheController()
         public Task SaveFileListToCache(string path, CacheEntry cacheEntry)
         {
             if (!App.AppSettings.UseFileListCache) return Task.CompletedTask;
+            if (cacheEntry == null)
+            {
+                filesCache.Remove(path);
+                return persistentAdapter.SaveFileListToCache(path, cacheEntry);
+            }
             filesCache.Set(path, cacheEntry, new MemoryCacheEntryOptions
             {
                 Size = cacheEntry.FileList.Count
             });
 
             // save entry to persistent cache in background
-            Task.Run(async () => await persistentAdapter.SaveFileListToCache(path, cacheEntry));
-            return Task.CompletedTask;
+            return persistentAdapter.SaveFileListToCache(path, cacheEntry);
         }
 
-        public async Task<CacheEntry> ReadFileListFromCache(string path)
+        public async Task<CacheEntry> ReadFileListFromCache(string path, CancellationToken cancellationToken)
         {
             if (!App.AppSettings.UseFileListCache) return null;
             var entry = filesCache.Get<CacheEntry>(path);
-            return entry ?? await persistentAdapter.ReadFileListFromCache(path);
+            if (entry == null)
+            {
+                entry = await persistentAdapter.ReadFileListFromCache(path, cancellationToken);
+                if (entry?.FileList != null)
+                {
+                    filesCache.Set(path, entry, new MemoryCacheEntryOptions
+                    {
+                        Size = entry.FileList.Count
+                    });
+                }
+            }
+            return entry;
         }
     }
 }

Files/Helpers/FileListCache/IFileListCache.cs

@@ -1,10 +1,11 @@
-using System.Threading.Tasks;
+using System.Threading;
+using System.Threading.Tasks;
 
 namespace Files.Helpers.FileListCache
 {
     internal interface IFileListCache
     {
-        public Task<CacheEntry> ReadFileListFromCache(string path);
+        public Task<CacheEntry> ReadFileListFromCache(string path, CancellationToken cancellationToken);
 
         public Task SaveFileListToCache(string path, CacheEntry cacheEntry);
     }

Files/Helpers/FileListCache/PersistentSQLiteCacheAdapter.cs

@@ -3,6 +3,8 @@
 using System;
 using System.Diagnostics;
 using System.IO;
+using System.Linq;
+using System.Threading;
 using System.Threading.Tasks;
 using Windows.Storage;
 
@@ -43,19 +45,33 @@ PRIMARY KEY(""Id"")
 
         public async Task SaveFileListToCache(string path, CacheEntry cacheEntry)
         {
+            const int maxCachedEntries = 128;
             try
             {
+                if (cacheEntry == null)
+                {
+                    using var deleteCommand = new SqliteCommand("DELETE FROM FileListCache WHERE Id = @Id", connection);
+                    deleteCommand.Parameters.Add("@Id", SqliteType.Text).Value = path;
+                    await deleteCommand.ExecuteNonQueryAsync();
+                    return;
+                }
+
+                if (cacheEntry.FileList.Count > maxCachedEntries)
+                {
+                    cacheEntry.FileList = cacheEntry.FileList.Take(maxCachedEntries).ToList();
+                }
+
                 using var cmd = new SqliteCommand("SELECT Id FROM FileListCache WHERE Id = @Id", connection);
                 cmd.Parameters.Add("@Id", SqliteType.Text).Value = path;
                 using var reader = await cmd.ExecuteReaderAsync();
                 if (reader.HasRows)
                 {
                     // need to update entry
-                    using var insertCommand = new SqliteCommand("UPDATE FileListCache SET Timestamp = @Timestamp, Entry = @Entry WHERE Id = @Id", connection);
-                    insertCommand.Parameters.Add("@Id", SqliteType.Text).Value = path;
-                    insertCommand.Parameters.Add("@Timestamp", SqliteType.Integer).Value = GetTimestamp(DateTime.UtcNow);
-                    insertCommand.Parameters.Add("@Entry", SqliteType.Text).Value = JsonConvert.SerializeObject(cacheEntry);
-                    await insertCommand.ExecuteNonQueryAsync();
+                    using var updateCommand = new SqliteCommand("UPDATE FileListCache SET Timestamp = @Timestamp, Entry = @Entry WHERE Id = @Id", connection);
+                    updateCommand.Parameters.Add("@Id", SqliteType.Text).Value = path;
+                    updateCommand.Parameters.Add("@Timestamp", SqliteType.Integer).Value = GetTimestamp(DateTime.UtcNow);
+                    updateCommand.Parameters.Add("@Entry", SqliteType.Text).Value = JsonConvert.SerializeObject(cacheEntry);
+                    await updateCommand.ExecuteNonQueryAsync();
                 }
                 else
                 {
@@ -73,14 +89,14 @@ public async Task SaveFileListToCache(string path, CacheEntry cacheEntry)
             }
         }
 
-        public async Task<CacheEntry> ReadFileListFromCache(string path)
+        public async Task<CacheEntry> ReadFileListFromCache(string path, CancellationToken cancellationToken)
         {
             try
             {
                 using var cmd = new SqliteCommand("SELECT Timestamp, Entry FROM FileListCache WHERE Id = @Id", connection);
                 cmd.Parameters.Add("@Id", SqliteType.Text).Value = path;
 
-                using var reader = await cmd.ExecuteReaderAsync();
+                using var reader = await cmd.ExecuteReaderAsync(cancellationToken);
                 if (!await reader.ReadAsync())
                 {
                     return null;

Files/Helpers/IntervalSampler.cs

@@ -0,0 +1,38 @@
+using System;
+
+namespace Files.Helpers
+{
+    class IntervalSampler
+    {
+        private DateTime recordPoint;
+        private TimeSpan sampleInterval;
+
+        public IntervalSampler(int millisecondsInterval)
+        {
+            sampleInterval = TimeSpan.FromMilliseconds(millisecondsInterval);
+            recordPoint = DateTime.Now;
+        }
+
+        public IntervalSampler(TimeSpan interval)
+        {
+            sampleInterval = interval;
+            recordPoint = DateTime.Now;
+        }
+
+        public void Reset()
+        {
+            recordPoint = DateTime.Now;
+        }
+
+        public bool CheckNow()
+        {
+            var now = DateTime.Now;
+            if (now - sampleInterval >= recordPoint)
+            {
+                recordPoint = now;
+                return true;
+            }
+            return false;
+        }
+    }
+}

Files/Interacts/Interaction.cs

@@ -1227,9 +1227,9 @@ await CoreApplication.MainView.CoreWindow.Dispatcher.RunAsync(CoreDispatcherPrio
             }
         }
 
-        public void PushJumpChar(char letter)
+        public Task PushJumpChar(char letter)
         {
-            AssociatedInstance.FilesystemViewModel.JumpString += letter.ToString().ToLower();
+            return AssociatedInstance.FilesystemViewModel.SetJumpStringAsync(AssociatedInstance.FilesystemViewModel.JumpString + letter.ToString().ToLower());
         }
 
         public async Task<string> GetHashForFileAsync(ListedItem fileItem, string nameOfAlg, CancellationToken token, Microsoft.UI.Xaml.Controls.ProgressBar progress)

Files/MultilingualResources/Files.hu-HU.xlf

@@ -2060,4 +2060,4 @@
       </group>
     </body>
   </file>
-</xliff>
+</xliff>

Files/MultilingualResources/Files.tr-TR.xlf

@@ -523,8 +523,9 @@
           <target state="translated">Yeni isim oluştur</target>
         </trans-unit>
         <trans-unit id="ItemAlreadyExistsDialogTitle" translate="yes" xml:space="preserve">
-          <source>Öğe zaten mevcut</source>
+          <source>Item already exists</source>
           <target state="needs-review-translation" state-qualifier="tm-suggestion">Öğe zaten mevcut</target>
+          <note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
         </trans-unit>
         <trans-unit id="ItemAlreadyExistsDialogSecondaryButtonText" translate="yes" xml:space="preserve">
           <source>Replace existing item</source>
@@ -2062,4 +2063,4 @@
       </group>
     </body>
   </file>
-</xliff>
+</xliff>

Files/Program.cs

@@ -11,7 +11,7 @@ namespace Files
 {
     internal class Program
     {
-        private static void Main()
+        private static async Task Main()
         {
             var args = Environment.GetCommandLineArgs();
             var proc = System.Diagnostics.Process.GetCurrentProcess();
@@ -27,7 +27,7 @@ private static void Main()
                         switch (command.Type)
                         {
                             case ParsedCommandType.ExplorerShellCommand:
-                                OpenShellCommandInExplorerAsync(command.Payload, proc.Id).GetAwaiter().GetResult();
+                                await OpenShellCommandInExplorerAsync(command.Payload, proc.Id);
                                 //Exit..
 
                                 return;

Files/Strings/hu-HU/Resources.resw

@@ -1518,4 +1518,10 @@
   <data name="StatusBarControlDetailsView.AutomationProperties.Name" xml:space="preserve">
     <value>Részletek</value>
   </data>
+  <data name="BaseLayoutContextFlyoutSortByDateDeleted.Text" xml:space="preserve">
+    <value>Törlés dátuma</value>
+  </data>
+  <data name="dateDeletedColumn.Header" xml:space="preserve">
+    <value>Törlés dátuma</value>
+  </data>
 </root>

Files/Strings/ru-RU/Resources.resw

@@ -55,7 +55,7 @@
     <value>Отправить отчет о проблеме, чтобы предоставить разработчикам больше информации о ней</value>
   </data>
   <data name="SettingsAboutThirdPartyLicenses.Text" xml:space="preserve">
-    <value>Third Party Licenses</value>
+    <value>Сторонние лицензии</value>
   </data>
   <data name="SettingsAboutTitle.Text" xml:space="preserve">
     <value>О приложении</value>
@@ -1413,4 +1413,28 @@
   <data name="SettingsDualPane.Text" xml:space="preserve">
     <value>Двойная панель</value>
   </data>
+  <data name="SettingsCopyLocationSwitch.Header" xml:space="preserve">
+    <value>Отображать пункт "Копировать местоположение"</value>
+  </data>
+  <data name="SettingsContextMenuOverflowSwitch.Header" xml:space="preserve">
+    <value>Переносить непомещающиеся пункты в подменю</value>
+  </data>
+  <data name="SettingsContextMenu.Text" xml:space="preserve">
+    <value>Настройки контекстного меню</value>
+  </data>
+  <data name="SettingsOpenInNewTabSwitch.Header" xml:space="preserve">
+    <value>Отображать пункт "Открыть в новой вкладке"</value>
+  </data>
+  <data name="LibraryWidgetDescription.Text" xml:space="preserve">
+    <value>Папки</value>
+  </data>
+  <data name="SettingsContextMenuAnimationsSwitch.Header" xml:space="preserve">
+    <value>Использовать анимации при открытии и закрытии контекстного меню</value>
+  </data>
+  <data name="StatusBarControlShowFileExtensions.Header" xml:space="preserve">
+    <value>Отображать расширения файлов</value>
+  </data>
+  <data name="StatusBarControlShowHiddenItems.Header" xml:space="preserve">
+    <value>Отображать скрытые файлы</value>
+  </data>
 </root>