Skip to content

Added the option to close tabs to the right #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 10, 2021
Merged

Added the option to close tabs to the right #3929

merged 6 commits into from
Mar 10, 2021

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Mar 10, 2021

For #260

@d2dyno1 d2dyno1 mentioned this pull request Mar 10, 2021
Closed
5 tasks
@yaira2 yaira2 self-requested a review March 10, 2021 15:38
@yaira2
Copy link
Member

yaira2 commented Mar 10, 2021

@d2dyno1 Can you disable the close tabs to right menu item when the user right clicks on the right-most tab?

yaira2
yaira2 requested changes Mar 10, 2021
View reviewed changes
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Mar 10, 2021
d2dyno1
d2dyno1 commented Mar 10, 2021
View reviewed changes
Copy link
Member Author

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions

yaira2
yaira2 requested changes Mar 10, 2021
View reviewed changes
@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 10, 2021

@yaichenbaum 👍

@d2dyno1 d2dyno1 requested a review from yaira2 March 10, 2021 18:11
@d2dyno1 d2dyno1 changed the title Added the option to close tabs to right Added the option to close tabs to the right Mar 10, 2021
yaira2
yaira2 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Mar 10, 2021
@yaira2 yaira2 merged commit 693c10f into files-community:main Mar 10, 2021
@d2dyno1 d2dyno1 deleted the cb_imp branch April 5, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

+1 more reviewer

@kal1ms kal1ms kal1ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d2dyno1 @yaira2 @kal1ms