Skip to content

Conversation

TyJOrtiz
Copy link
Contributor

code for column-view and pages

Resolved / Related Issues

Itemize resolved / related issues by this PR.
Added code relevant to Column View.

Details of Changes

Add details of changes here.

  • added Column View to LayoutModes enums
  • added ColumnView seitch commands

Validation

How did you test these changes?

  • Built and ran the app

Screenshots (optional)

Add screenshots here.
image

@yaira2 yaira2 mentioned this pull request Mar 19, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Mar 19, 2021

Re-implementation of #2500

InitializeCommands() and Dispose()
BaseLayoutContextFlyoutColumn
d2dyno1
d2dyno1 previously approved these changes Mar 23, 2021
further column view code (opening new columns, renaming, etc.)

Not final
Copy link
Contributor Author

@TyJOrtiz TyJOrtiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 30, 2021
@yaira2
Copy link
Member

yaira2 commented Mar 30, 2021

@TyJOrtiz I am merging this with the intention that we will continue working on it and make sure everything is working before releasing it to users.

@yaira2 yaira2 merged commit 7155def into files-community:main Mar 30, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Mar 30, 2021

🚀 🎊

@TyJOrtiz
Copy link
Contributor Author

Ok cool.

There's like only a couple things that I need help with to make it ready to ship.

@yaira2
Copy link
Member

yaira2 commented Mar 30, 2021

@TyJOrtiz That's great! Can you open issues so we can keep track of what still needs to be done?

@yaira2 yaira2 changed the title re-introducing column-view Added column view layout Mar 30, 2021
@TyJOrtiz
Copy link
Contributor Author

How do I reopen this PR

@yaira2
Copy link
Member

yaira2 commented Mar 31, 2021

@TyJOrtiz I think you need to open a new one since this was already merged.

@TyJOrtiz TyJOrtiz mentioned this pull request Mar 31, 2021
2 tasks
@files-community files-community deleted a comment from TyJOrtiz Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants