Added drill-in animation to homepage navigation #4293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d2dyno1 This change hasn't been approved yet, can you share a screen recording of the animation? |
The animation video is in the description. There's not much code but I wanted to show (additionally merge) how would this animation look like. @yaichenbaum |
|
@d2dyno1 How does it look when first opening the app and when opening a new tab? |
2021-03-25.15-52-55.mp42021-03-25.15-53-31.mp4 |
|
@d2dyno1 The changes look good! In the future, make sure to open an issue first to prevent extra work in the event we don't merge your changes. |
yaira2
approved these changes
Mar 25, 2021
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of Changes
This PR adds a drill-in animation transition to the home page.
Validation
How did you test these changes?
Screenshots
2021-03-25.15-08-20.mp4